Skip to content

Find the entity of a restored entity ticket in its cube - #159

Merged
RecursivePineapple merged 1 commit into
GTNewHorizons:masterfrom
JakfutCC:fix-entity-ticket-restore
Oct 31, 2026
Merged

RecursivePineapple merged 1 commit into
GTNewHorizons:masterfrom
JakfutCC:fix-entity-ticket-restore

Conversation

@Jakfut

@Jakfut Jakfut commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Chunkloading entities, like Steve's Carts with the chunk loader module, lost their chunk loading on every server restart. Forge restores an entity ticket by loading the entity's chunk and finding the entity in it, if it is not found, the ticket is dropped. In CC that chunk should be a cube, and two things went wrong

  • MixinForgeChunkManager.injectLoadEntityCube, which loads the entity's cube, never ran outside the dev environment. The injector has remap = false, so its target, the vanilla World.getChunkFromChunkCoords, was not remapped and matched nothing.
  • The entity's cube Y was never saved. onSerializeTicket wrote getEntityChunkY(), which nothing set. Now the bound entity's chunkCoordY is saved for entity tickets and restored, so the cube that holds the entity is loaded.

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@RecursivePineapple
RecursivePineapple merged commit 068a17b into GTNewHorizons:master Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants