[TASK] Remove CSH generation, use TCA description field instead

Classes/Service/FileGenerator.php

@@ -439,13 +439,7 @@ protected function generateLocallangFiles(): void
                     );
                 }
             }
-            foreach ($this->extension->getDomainObjects() as $domainObject) {
-                $fileContents = $this->generateLocallangFileContent('_csh_' . $domainObject->getDatabaseTableName() . '.xlf', 'domainObject', $domainObject);
-                $this->writeFile(
-                    $this->languageDirectory . 'locallang_csh_' . $domainObject->getDatabaseTableName() . '.xlf',
-                    $fileContents
-                );
-            }
+
         } catch (Exception $e) {
             throw new Exception('Could not generate locallang files, error: ' . $e->getMessage());
         }
@@ -1251,7 +1245,7 @@ public function generateLayout(string $templateRootFolder): ?string
     }
 
     /**
-     * @param string $fileNameSuffix (_db, _csh, _mod)
+     * @param string $fileNameSuffix (_db, _mod)
      * @param string $variableName
      * @param DomainObject|BackendModule $variable
      *
@@ -1293,10 +1287,6 @@ protected function generateLocallangFileContent(string $fileNameSuffix = '', str
 
     protected function getLanguageLabelsForVariable(string $variableName, $variable, string $fileNameSuffix): array
     {
-        if ($variableName === 'domainObject') {
-            return $this->localizationService->prepareLabelArrayForContextHelp($variable);
-        }
-
         if ($variableName === 'backendModule') {
             return $this->localizationService->prepareLabelArrayForBackendModule($variable);
         }

Classes/Service/LocalizationService.php

@@ -88,21 +88,6 @@ public function prepareLabelArray(Extension $extension, string $type = 'locallan
         return $labelArray;
     }
 
-    /**
-     * @param DomainObject $domainObject
-     *
-     * @return array
-     * @throws InvalidArgumentException
-     */
-    public function prepareLabelArrayForContextHelp(DomainObject $domainObject): array
-    {
-        $labelArray = [];
-        foreach ($domainObject->getProperties() as $property) {
-            $labelArray[$property->getFieldName() . '.description'] = htmlspecialchars($property->getDescription());
-        }
-        return $labelArray;
-    }
-
     public function prepareLabelArrayForBackendModule(BackendModule $backendModule): array
     {
         return [

Classes/Service/RoundTrip.php

@@ -1266,11 +1266,12 @@ protected function removeDomainObjectFiles(DomainObject $domainObject): void
         // other files
         $iconsDirectory = $this->extensionDirectory . 'Resources/Public/Icons/';
         $languageDirectory = $this->extensionDirectory . 'Resources/Private/Language/';
-        $locallang_cshFile = $languageDirectory . 'locallang_csh_' . $domainObject->getDatabaseTableName() . '.xml';
         $iconFile = $iconsDirectory . $domainObject->getDatabaseTableName() . '.gif';
-        if (file_exists($locallang_cshFile)) {
-            // no overwrite settings check here...
-            unlink($locallang_cshFile);
+        foreach (['xml', 'xlf'] as $cshExt) {
+            $cshFile = $languageDirectory . 'locallang_csh_' . $domainObject->getDatabaseTableName() . '.' . $cshExt;
+            if (file_exists($cshFile)) {
+                unlink($cshFile);
+            }
         }
         if (file_exists($iconFile)) {
             unlink($iconFile);