[TASK] Remove CSH generation, use TCA description field instead#818
Merged
[TASK] Remove CSH generation, use TCA description field instead#818
Conversation
CSH was removed in TYPO3 v12. The TCA description key in locallang_db.xlf already serves as the replacement — descriptions are written there via prepareLabelArray() and referenced in PropertiesDefinition.phpt. - Remove locallang_csh_*.xlf generation loop from FileGenerator - Remove prepareLabelArrayForContextHelp() from LocalizationService - Extend RoundTrip cleanup to also remove legacy .xlf CSH files - Delete 15 locallang_csh_*.xlf fixture files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PKuhlmay
force-pushed
the
feature/issue-647-remove-csh-generation
branch
from
bad41ac to
4b0dbcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locallang_csh_*.xlfgeneration fromFileGenerator— CSH was removed in TYPO3 v12prepareLabelArrayForContextHelp()fromLocalizationService(now unused)RoundTripcleanup to delete legacy CSH files (.xmland.xlf) when a domain object is removedlocallang_csh_*.xlffixture files from test extensionsField descriptions are already written to
locallang_db.xlfviaprepareLabelArray()and the TCA template (PropertiesDefinition.phpt) already references them via thedescriptionkey — CSH files were fully redundant.Closes #647
Test plan
locallang_db.xlf, no CSH files generated🤖 Generated with Claude Code