Repository navigation
fix(#144): MEDIUM: the user id is baked into every CalDAV collection path and calendar_id, - #432
Merged
Merged
Conversation
In AUTH_METHOD=oidc the OIDC sub is now the storage identity everywhere: the internal Radicale account URL and login, booking accounts, calendar access (owner and shares matched only by user id, no login-name lookup), share invitations and the Radicale auth plugin (exact user id match first); a sub that is not one safe path segment is refused with 401 at the OIDC callback and the proxy header, never rewritten. This closes the account/rights mismatch that hid OIDC users' calendars and the leak that let a member whose login name equals another sub act as that member; two obsolete login-name test cases were updated and CONCEPTS.md now records the decision. Refs #144 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #144
In AUTH_METHOD=oidc the OIDC sub is now the storage identity everywhere: the internal Radicale account URL and login, booking accounts, calendar access (owner and shares matched only by user id, no login-name lookup), share invitations and the Radicale auth plugin (exact user id match first); a sub that is not one safe path segment is refused with 401 at the OIDC callback and the proxy header, never rewritten. This closes the account/rights mismatch that hid OIDC users' calendars and the leak that let a member whose login name equals another sub act as that member; two obsolete login-name test cases were updated and CONCEPTS.md now records the decision.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code