Skip to content

fix(#110): MEDIUM: the stylesheet and the markup have drifted — seven undefined custom prop - #427

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-110
Oct 15, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-110

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #110

Added the toast warning variant (CSS + icon), replaced undefined var(--primary) with --line, gave the unstyled classes (attendee-status, empty-state, kanban-card-body, sidebar-task-*, recur-icon, google-badge-icon, btn-msgraph) real rules while moving their inline styles into CSS and dropping no-op flex-1/all-day, and deleted the dead compatibility block, dead print/utility selectors and the duplicate .sidebar rule (print rules now target the real grid/agenda elements; print_stylesheet.test.js updated to match). Covered by four Playwright tests reading computed styles and a node test checking, across all of public/, that every custom property is defined, every class selector is used, and no top-level rule appears twice.

Driver gates (measured, not claimed)

  • Suites: lint: 1 passed, 0 failed | node: 1767 passed, 0 failed | python: 104 passed, 0 failed | e2e: 68 passed, 0 failed
  • Red/green check on declared tests: server/test/issue110_stylesheet_markup_drift.test.js, e2e/calendar.spec.js
red/green output
RED without the change:
[WebServer]     at trim_prefix (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:328:13)
[WebServer]     at /home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:286:9
[WebServer]     at Function.process_params (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:346:12)
[WebServer]     at next (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:280:10)
[WebServer]     at /home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express-session/index.js:521:7
[WebServer] [MSGraph OAuth] authorization was not granted


GREEN with the change:
[WebServer]     at trim_prefix (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:328:13)
[WebServer]     at /home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:286:9
[WebServer]     at Function.process_params (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:346:12)
[WebServer]     at next (/home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express/lib/router/index.js:280:10)
[WebServer]     at /home/agent-user/Coding/Freeshard/vacation_framework/worktrees/issue-110/node_modules/express-session/index.js:521:7
[WebServer] [MSGraph OAuth] authorization was not granted

🤖 Generated with Claude Code

Added the toast warning variant (CSS + icon), replaced undefined var(--primary) with --line, gave the unstyled classes (attendee-status, empty-state, kanban-card-body, sidebar-task-*, recur-icon, google-badge-icon, btn-msgraph) real rules while moving their inline styles into CSS and dropping no-op flex-1/all-day, and deleted the dead compatibility block, dead print/utility selectors and the duplicate .sidebar rule (print rules now target the real grid/agenda elements; print_stylesheet.test.js updated to match). Covered by four Playwright tests reading computed styles and a node test checking, across all of public/, that every custom property is defined, every class selector is used, and no top-level rule appears twice.

Refs #110

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant