Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 54.00% 53.55% -0.46%
==========================================
Files 120 120
Lines 16565 16712 +147
==========================================
+ Hits 8946 8950 +4
- Misses 7619 7762 +143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Sorry for the delay. Some things I noticed when testing it:
|
Owner
|
I can take a look at these if preferred. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fuzzy search to the help dialog spawned by
?shortcut.Screenshots
Default help menu
Help menu going into search mode when
/is pressedHelp menu filtered based on input query =
selecIssue
Closes: #1790
Testing
Distro: Arch
Checklist
Ensure all of these are met:
cargo fmt)cargo clippy --all -- -D warningscargo testREADME.md, help menu, docs, configs, etc.)Other
Currently, the search operates over all text in the help menu. That includes extra information such as the supported search types shown in the process search widget (which appears to be incorrect, for example, it claims read >= 1mb is supported, but it is not.)
I would like to know whether we can remove this extra information from the main help text or move it into a separate pane.