refactor: generalize input field logic for easier reuse#2035
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2035 +/- ##
==========================================
+ Coverage 54.04% 55.35% +1.31%
==========================================
Files 122 123 +1
Lines 17049 17278 +229
==========================================
+ Hits 9214 9565 +351
+ Misses 7835 7713 -122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5bfdc25 to
9cb9a0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (e.g. UI changes), please also provide screenshots/recordings:
This came up while I was reviewing/updating #1953 - we probably want to generalize the really hairy input field logic so it can be reused anywhere. This PR further generalizes it so it's not as tied into app state logic. It also fixes a found bug around deleting whole words if they were were more than one byte long.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested (including steps):
If this change affects the program, please also indicate which platforms were tested:
Checklist
Ensure all of these are met:
cargo fmt)cargo clippy --all -- -D warningscargo testREADME.md, help menu, docs, configs, etc.)Other
Anything else that maintainers should know about this PR: