Uds02 2144#1735
Open
spaceperson wants to merge 96 commits into
Open
Conversation
# [@asu/component-header-footer-v1.4.3](https://github.com/asu/asu-unity-stack/compare/@asu/component-header-footer-v1.4.2...@asu/component-header-footer-v1.4.3) (2026-05-28) ### Bug Fixes * **component-header-footer:** check undefined ([401b606](401b606)) * **component-header-footer:** fix animated header option ([267968e](267968e))
# [@asu/unity-bootstrap-theme-v1.39.0](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.38.2...@asu/unity-bootstrap-theme-v1.39.0) (2026-05-28) ### Bug Fixes * **unity-bootstrap-theme:** update header styles and stories ([88c018d](88c018d)) ### Features * **unity-bootstrap-theme:** added new header styles and stories ([c4f8d1d](c4f8d1d))
Move .btn-row out of position:absolute (with hard-coded top:15rem) into grid-row:4 with position:relative, matching the existing tablet+ pattern. The container now expands naturally to contain the button instead of overflowing at viewports between mobile and the 768px breakpoint (reproduced at 764x921). Adds margin-top:1rem to give the requested breathing room between heading and button. Scoped to uds-hero-sm only.
…adding QA feedback on UDS-2171 requested more breathing room between the small hero CTA button and the bottom edge of the hero. Add margin-bottom: 1rem on .btn-row, symmetric to the existing margin-top: 1rem, scoped to uds-hero-sm.has-btn-row only. uds-hero-md and uds-hero-lg unchanged.
# [@asu/unity-bootstrap-theme-v1.39.1](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.0...@asu/unity-bootstrap-theme-v1.39.1) (2026-06-05) ### Bug Fixes * **unity-bootstrap-theme:** add bottom margin to hero-sm CTA for QA padding ([d6c217d](d6c217d)) * **unity-bootstrap-theme:** hero small CTA overflow at <768px viewports ([bebb98c](bebb98c))
# [@asu/unity-bootstrap-theme-v1.39.2](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.1...@asu/unity-bootstrap-theme-v1.39.2) (2026-06-05) ### Bug Fixes * **unity-bootstrap-theme:** space bar expands/collapses footer accordion (UDS-2159) ([22f2133](22f2133))
# [@asu/unity-bootstrap-theme-v1.39.3](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.2...@asu/unity-bootstrap-theme-v1.39.3) (2026-06-05) ### Bug Fixes * **anchor-menu:** use native button for the mobile toggle (WCAG 2.1.1, 4.1.2) ([d33bda3](d33bda3))
# [@asu/unity-react-core-v1.11.1](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.0...@asu/unity-react-core-v1.11.1) (2026-06-05) ### Bug Fixes * **anchor-menu:** use native button for the mobile toggle (WCAG 2.1.1, 4.1.2) ([d33bda3](d33bda3))
…CAG 1.4.10) In mobile landscape orientations the sticky anchor menu was position:fixed with no height constraint or overflow handling, so the expanded menu overflowed the viewport and the lower links were unreachable. Cap the sticky container to the viewport using 100dvh (with 100vh fallback) and enable overflow-y: auto below the lg breakpoint, in both the unity-bootstrap-theme SCSS and the unity-react-core styled-component. The React version subtracts --uds-anchor-menu-top to account for the global header offset. Fixes WCAG 1.4.10 Reflow (Level AA).
…menu The previous selector .uds-anchor-menu-sticky never matched any element in real consumers because the JS attaches the navbar to the global header via .uds-anchor-menu-attached (-sticky is dead code left over from the BS5 migration). Add -attached so the WCAG 1.4.10 fix actually applies in Webspark/Drupal sites, and keep -sticky for any external code that may apply it manually.
…o bootstrap theme Per review, avoid growing the styled-component surface in unity-react-core ahead of the planned migration of *.styles.js into unity-bootstrap-theme. The React component already relies on the bootstrap theme SCSS for its base styling, so target its .sticky class there alongside the bootstrap JS -attached/-sticky classes. The shared max-height uses calc(100dvh - var(--uds-anchor-menu-top, 0px)); the offset defaults to 0px, reducing to 100dvh for the bootstrap/static markup cases.
# [@asu/unity-bootstrap-theme-v1.39.4](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.3...@asu/unity-bootstrap-theme-v1.39.4) (2026-06-12) ### Bug Fixes * **anchor-menu:** constrain sticky menu height in mobile landscape (WCAG 1.4.10) ([19b8bb4](19b8bb4)) * **unity-bootstrap-theme:** target the actual sticky class on anchor menu ([77b6fa6](77b6fa6))
# [@asu/unity-react-core-v1.11.2](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.1...@asu/unity-react-core-v1.11.2) (2026-06-12) ### Bug Fixes * **anchor-menu:** constrain sticky menu height in mobile landscape (WCAG 1.4.10) ([19b8bb4](19b8bb4))
Bumps [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser) from 4.1.6 to 4.1.8. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/browser) --- updated-dependencies: - dependency-name: "@vitest/browser" dependency-version: 4.1.8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.5 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.5...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
# [@asu/unity-react-core-v1.11.3](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.2...@asu/unity-react-core-v1.11.3) (2026-06-18) ### Bug Fixes * **unity-react-core:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([9af53fb](9af53fb))
mlsamuelson
requested changes
Jul 10, 2026
mlsamuelson
left a comment
mlsamuelson
left a comment
Member
There was a problem hiding this comment.
Redo the PR against the latest Dev. There's a lot of extra commits here and that's the easiest path.
Add an optional noFeedText prop to CardsGridEvents and CardsListEvents, propagated through BaseFeed to FeedContainerProvider in place of the hardcoded "No events to show." string. Defaults to the original text so existing consumers are unaffected. - Add noFeedText to propTypes and BaseFeed propTypes - Add Storybook stories and unit tests for the override behavior - Bump package to 3.2.0 and update changelog
semantic-release generates these in the pipeline
An empty or whitespace-only noFeedText now renders the default "No events to show." instead of an empty message
# [@asu/component-events-v3.2.0](https://github.com/asu/asu-unity-stack/compare/@asu/component-events-v3.1.0...@asu/component-events-v3.2.0) (2026-07-14) ### Bug Fixes * **component-events:** fall back to default noFeedText when blank ([e85d4da](e85d4da)) ### Features * **component-events:** expose configurable noFeedText prop ([9cac3e9](9cac3e9))
# [@asu/unity-bootstrap-theme-v1.39.6](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.5...@asu/unity-bootstrap-theme-v1.39.6) (2026-07-14) ### Bug Fixes * **unity-bootstrap-theme:** keep hero CTA inside the hero box below md breakpoint ([0057cd4](0057cd4))
…no CTA is present On md+ viewports, grid row 4 of uds-hero-sm collapses to 0 when the hero has no CTA button, leaving the h1 flush against the bottom edge. Carry the bottom spacing on the h1 instead, and reset it to 0 when a CTA is present (via .has-btn-row or the :has(> a.btn) fallback).
# [@asu/unity-bootstrap-theme-v1.39.7](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.39.6...@asu/unity-bootstrap-theme-v1.39.7) (2026-07-14) ### Bug Fixes * **unity-bootstrap-theme:** add bottom spacing to hero-sm title when no CTA is present ([51ebf35](51ebf35))
undo background implementation
remove reactstrap - package is no longer updated and does not support react19 - BreadcrumbItem converted to native LI element update react-share - update prop quote to title - add aria-label - update email share to proper usage (drafts share email, rather than using mailto:authorEmail link) - add console warning if required article prop is undefined, but still allows render
… A/Unity) Self-contained .kiro pipeline seeded from ddt-agent-skills-library-foundry: 5 acp-* agents (orchestrator/architect/coder/reviewer/visual), foundry + ASU skills (jira-figma-intake, unity-components, asu-design-a11y, asu-brand, unity-handoff-out, visual-diff), project-local MCP (Atlassian RO, Figma, Storybook), steering, hooks, preflight + handoff validator, README. Agents stop at branch+commits; humans open PRs.
…doff interactivity contract (schema 1.1) RETAIN step archives reports to .pipeline/archive/<slug>-<UTC>/ and optionally attaches them + posts a summary comment to the Jira ticket via v3 REST. Handoff schema 1.1 adds an interactivity block (state machine, activation, keyboard/APG, focus, dynamic ARIA, class-toggle contract, motion/forced-colors, breakpoints, analytics) so Webspark reproduces behavior instead of reinventing it. Validator warns when absent.
Contributor
|
I believe this is having the same issues as #1727 and it might be the same ticket? @spaceperson |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Important Reminders
Links