fix(unity-react-core): replaced fa-exclamation-triangle with the corr…#1738
Open
spaceperson wants to merge 97 commits into
Open
fix(unity-react-core): replaced fa-exclamation-triangle with the corr…#1738spaceperson wants to merge 97 commits into
spaceperson wants to merge 97 commits into
Conversation
…ect style for valid-feedback
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1738/index.html |
mlsamuelson
reviewed
Jul 6, 2026
mlsamuelson
left a comment
mlsamuelson
left a comment
Member
There was a problem hiding this comment.
The spans where the icons have been changed have title="Alert" in them... Does that need to be corrected, too?
Note: the form input stories exist in unity-bootstrap-theme but not in the unity-react-core if memory serves. May want to take some time to make sure things are in order, since this one is a bit difrerent.
# [@asu/unity-react-core-v1.10.1](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.10.0...@asu/unity-react-core-v1.10.1) (2026-05-08) ### Bug Fixes * **unity-react-core:** only render heading element if heading is passed in ([af876a4](af876a4))
# [@asu/component-header-footer-v1.4.1](https://github.com/asu/asu-unity-stack/compare/@asu/component-header-footer-v1.4.0...@asu/component-header-footer-v1.4.1) (2026-05-12) ### Bug Fixes * **component-header-footer:** fix header dropdown height ([efa0bb7](efa0bb7))
# [@asu/unity-bootstrap-theme-v1.38.1](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-bootstrap-theme-v1.38.0...@asu/unity-bootstrap-theme-v1.38.1) (2026-05-13) ### Bug Fixes * **unity-bootstrap-theme:** blockquote css update for maxwidth standards ([92976a5](92976a5)) * **unity-bootstrap-theme:** padding-left: 0 applied to uds-blockquote ([aa558f6](aa558f6)) * **unity-bootstrap-theme:** removed padding right from the blockquote css ([ff90b82](ff90b82))
# [@asu/app-webdir-ui-v5.0.13](https://github.com/asu/asu-unity-stack/compare/@asu/app-webdir-ui-v5.0.12...@asu/app-webdir-ui-v5.0.13) (2026-05-19) ### Bug Fixes * **app-webdir-ui:** update search page input and results styles ([8f9f361](8f9f361))
Bumps [axios](https://github.com/axios/axios) from 1.15.0 to 1.15.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.15.0...v1.15.2) --- updated-dependencies: - dependency-name: axios dependency-version: 1.15.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [simple-git](https://github.com/steveukx/git-js/tree/HEAD/simple-git) from 3.33.0 to 3.36.0. - [Release notes](https://github.com/steveukx/git-js/releases) - [Changelog](https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md) - [Commits](https://github.com/steveukx/git-js/commits/simple-git@3.36.0/simple-git) --- updated-dependencies: - dependency-name: simple-git dependency-version: 3.36.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.3 to 8.5.10. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.3...8.5.10) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.10 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.0.6 to 3.1.2. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.0.6...v3.1.2) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/plugin-transform-modules-systemjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-systemjs) from 7.25.9 to 7.29.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.4/packages/babel-plugin-transform-modules-systemjs) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-modules-systemjs" dependency-version: 7.29.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump styled-components from ^5.3.0 to ^6.0.0 across all 6 packages that depend on it, as preparation for React 19 upgrade. Update .attrs() call sites in app-degree-pages to use the v6 function signature.
Bump react and react-dom to ^19.0.0 in root devDependencies and unity-react-core devDependencies and peerDependencies. Remove @types/react-dom from root (React 19 bundles its own types).
Bump react and react-dom to ^19.0.0. Remove @types/react and @types/react-dom (React 19 bundles its own types).
Bump react and react-dom peerDependencies to ^19.0.0. Remove @types/react resolutions (React 19 bundles its own types).
Bump react and react-dom peerDependencies to ^19.0.0.
Bump react and react-dom peerDependencies to ^19.0.0.
Bump react and react-dom peerDependencies to ^19.0.0.
Bump react and react-dom peerDependencies to ^19.0.0.
Bumps [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser) from 4.1.6 to 4.1.8. - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/browser) --- updated-dependencies: - dependency-name: "@vitest/browser" dependency-version: 4.1.8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.5 to 3.4.9. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.5...3.4.9) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.9 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
# [@asu/unity-react-core-v1.11.3](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.2...@asu/unity-react-core-v1.11.3) (2026-06-18) ### Bug Fixes * **unity-react-core:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([9af53fb](9af53fb))
# [@asu/app-degree-pages-v3.2.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-degree-pages-v3.2.0...@asu/app-degree-pages-v3.2.1) (2026-06-18) ### Bug Fixes * **app-degree-pages:** bumps @vitest/browser from 4.1.6 to 4.1.9 ([e3ae108](e3ae108))
# [@asu/app-rfi-v3.10.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v3.10.0...@asu/app-rfi-v3.10.1) (2026-06-18) ### Bug Fixes * **app-rfi:** bumps dompurify from 3.4.5 to 3.4.10 ([f07a003](f07a003))
With SB10 upgrade, module graph changed and import behavior caused an error in html panel addon
Bumps [ws](https://github.com/websockets/ws) from 6.2.3 to 6.2.4. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.4) --- updated-dependencies: - dependency-name: ws dependency-version: 6.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [undici](https://github.com/nodejs/undici) from 6.25.0 to 6.27.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.25.0...v6.27.0) --- updated-dependencies: - dependency-name: undici dependency-version: 6.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.9 to 2.0.10. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.10/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.9...v2.0.10) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.10 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
undo background implementation
# [@asu/component-header-footer-v1.4.4](https://github.com/asu/asu-unity-stack/compare/@asu/component-header-footer-v1.4.3...@asu/component-header-footer-v1.4.4) (2026-07-01) ### Bug Fixes * **component-header-footer:** adjust layout add dropdown examples ([07b980c](07b980c)) * **component-header-footer:** col divider bg fix ([cbc8216](cbc8216)) * **component-header-footer:** col divider bg fix ([85b69be](85b69be)) * **component-header-footer:** col divider bg fix ([4dbe1ac](4dbe1ac)) * **component-header-footer:** col divider bg fix ([ffd1bef](ffd1bef))
remove reactstrap - package is no longer updated and does not support react19 - BreadcrumbItem converted to native LI element update react-share - update prop quote to title - add aria-label - update email share to proper usage (drafts share email, rather than using mailto:authorEmail link) - add console warning if required article prop is undefined, but still allows render
remove reactstrap - package is no longer updated and does not support react19
# [@asu/unity-react-core-v1.11.4](https://github.com/ASU/asu-unity-stack/compare/@asu/unity-react-core-v1.11.3...@asu/unity-react-core-v1.11.4) (2026-07-01) ### Bug Fixes * **unity-react-core:** update or remove pkg to support react 19 ([7db1f8b](7db1f8b))
# [@asu/app-rfi-v3.10.2](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v3.10.1...@asu/app-rfi-v3.10.2) (2026-07-01) ### Bug Fixes * **app-rfi:** remove pkg to support react 19 ([3eec4b8](3eec4b8))
… success messages
Contributor
|
Same issue as #1735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ect style for valid-feedback
Description
Checklist
Important Reminders
Links