Repository navigation
fix(deps): patch the zod, happy-dom and undici advisories - #7
Merged
Merged
Conversation
pnpm audit fails on main with five advisories published after 2026-10-23: zod GHSA-mrhx-c7xc-m3w5 (high, fixed in 4.6.6), happy-dom GHSA-834v-8h66-3h79 (high, fixed in 21.0.4) and undici GHSA-xjj6-f33q-929c, GHSA-4qv8-2p9j-2685 and GHSA-f72v-6w45-q472 (one high, two moderate, fixed in 7.30.1). zod and happy-dom move to the first fixed release. Every miniflare release, including the one in the latest wrangler, pins undici 7.29.1, so undici is raised to 7.30.1 with an override scoped to miniflare's own dependency. happy-dom 21.0.4 is four days old, so it is listed in minimumReleaseAgeExclude for that one version; the entry can be removed on 2026-10-27, when the version passes the seven-day rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pnpm auditin theverifyjob fails onmain(0438851) with five advisories published after 2026-10-23, when the identical source tree was green.verifyis a required check, so every pull request is blocked until this lands..>zod.>happy-dom,.>vitest>happy-dom.>wrangler>miniflare>undiciWhat changes
Dependency files only (
package.json,pnpm-workspace.yaml,pnpm-lock.yaml); no application source.zod4.6.5 -> 4.6.6, the first patched release (exact pin, like every other dependency). 4.6.7 exists but differs from 4.6.6 only in the version string.happy-dom(dev, test DOM) 20.14.6 -> 21.0.4. 21.0.4 is the first fixed release; vitest 5.0.3 accepts any happy-dom (peerDependencies: "*").undici7.29.1 -> 7.30.1 through a pnpm override scoped tominiflare>undici. Every miniflare release up to the one wrangler 4.152.0 (the latest) pulls in pins undici 7.29.1 exactly, so bumping wrangler cannot fix this. The override is scoped to miniflare's own dependency, is an exact version, stays inside undici 7.x (the range miniflare asks for), and has a comment saying when to remove it. Nothing else resolves undici.minimumReleaseAgeExclude: happy-dom@21.0.4inpnpm-workspace.yaml. See the next section.The 7-day release-age rule
The project resolves only package versions at least seven days old.
happy-dom@21.0.4, with a comment. The rule stays on for every other package, and the exception becomes redundant on 2026-10-27 and can be deleted then.Because it is a deliberate, narrow exception to a supply-chain rule, I compared the published tarballs before using it: happy-dom 21.0.3 vs 21.0.4 differs in 7 source files (
ECMAScriptModuleCompiler,BrowserFrameNavigator,BrowserFrameURL,HTMLIFrameElement,PublicSuffixList,CSSPropertyList,ICSSStyleDeclaration; I read theECMAScriptModuleCompilerchange, which is the alias validation the advisory describes, and only skimmed the rest) with no new dependencies, no install scripts, and npm provenance attestations present. undici 7.29.1 vs 7.30.1 differs only in library code (decompress interceptor, EventSource parser, SRI token parsing, cookies, websocket, H1/H2 client), also with provenance and no dependencies or install scripts.If you would rather not carry the exception, the alternative is to wait until 2026-10-27 and drop that one line;
mainwould stay red until then.Verified locally (Windows, Node 24.16.0, pnpm 11.7.0)
pnpm installregenerated the lockfile;pnpm install --frozen-lockfileis then a no-oppnpm audit: No known vulnerabilities foundpnpm exec tsc -b --noEmit,pnpm typecheck:worker: passpnpm test: 45 files, 655 tests passpnpm scan:secrets: no findingspnpm build: succeeds (the existing large-chunk warning is unchanged)STUDYAI_E2E_PORT_BASE=24000 pnpm test:e2e: 72 passed, 2 skipped (the two that needSTUDYAI_REAL_LECTURE/STUDYAI_REAL_PACKorSTUDYAI_SCREENSHOTS, which are off by default)