Repository navigation
docs: correct the FSRS version and two stale claims - #4
Merged
Merged
Conversation
- The docs and a source comment said the scheduler is FSRS-5. The pinned ts-fsrs 5.4.2 implements FSRS-6 (FSRSVersion reports "v5.4.2 using FSRS-6.0", 21 default weights, checked by running it). Fix the comment in fsrs.ts and add a dated correction to ADR-012; the decision is unchanged. - docs/ARCHITECTURE.md drew a "Claude API (disabled by default)" arrow out of the Worker, but the adapter is not wired into the Worker (docs/FINANCIAL-SAFETY.md section 5, and nothing in worker/ or the app imports it). Draw only the Gemini path and say so below the diagram. - A test title said "the app has no AI call path yet", which has been false since the app started calling the Worker's /api endpoints. Reword it; the assertion is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
zuhairhalawa
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in studyai #4 (FSRS version, unwired Claude arrow, stale test title) and #5 (shared file-rejection message, strict dev port, README notes). One conflict, in vite.config.ts: main added a `server` block to the old object-literal config while this branch turned the config into a function of the mode. Resolved by keeping the function form and carrying the strict dev-port block (port 5173, strictPort) into it, so it applies to the regular and the demo dev servers alike. docs/ARCHITECTURE.md and docs/DECISIONS.md merged without conflict and were read afterwards: the corrected diagram and ADR-012 correction from main sit alongside this branch's src/demo row and ADR-037. Co-Authored-By: Claude <noreply@anthropic.com>
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three factual corrections, found while checking the repository before a first release.
FSRS-5 is FSRS-6. The docs and a source comment said FSRS-5. The pinned
ts-fsrs5.4.2 reportsv5.4.2 using FSRS-6.0with 21 default weights (checked by running it). Fixes the comment infsrs.tsand adds a dated correction to ADR-012; the decision itself is unchanged.Unwired Claude arrow.
docs/ARCHITECTURE.mddrew a "Claude API (disabled by default)" arrow out of the Worker, but the adapter is not wired into the Worker (FINANCIAL-SAFETY.md section 5; nothing inworker/or the app imports it). The diagram now shows only the Gemini path and says so.Stale test title. "the app has no AI call path yet" has been false since the app started calling the Worker's
/apiendpoints. Title reworded; the assertion is unchanged.Checked locally:
tsc -b --noEmit,pnpm test(39 files, 608 tests),scan-secrets. No behaviour changes.