Repository navigation
Allow an explicit no-accent value and stop OK from stepping settings - #4
Merged
Merged
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the accent stripe appearing when the client had it switched off. The API had no way to say "no stripe" once the TV's default accent was set, and pressing OK on a settings row silently stepped its value, which is how the TV default got set in the first place.
Changes
Treat an explicit empty accent as no stripe:accentsent as"none",""ornullnow forces no stripe even when the TV has a default accent; omitting the field still means "use the TV default". Wrong types name the field in the 400 response. Two new parser tests; README field table updated.Send an explicit no-accent value from the client: the compose form sends"accent": "none"when the switch is off, so the preview matches the TV regardless of TV defaults. The blocked-send and unreachable messages now mention checking that the port is 8090, since a wrong port produced the same browser error as a mixed-content block.Stop OK from stepping settings values: settings rows only change on left and right; OK does nothing, matching the◀ value ▶hint.Testing
./gradlew testDebugUnitTest assembleDebug: 59 tests pass, APK builds.npm run build && npm run lintclean."accent": "none"reachesNotificationCardView.bindwithaccent == null, which hides the stripe.Checklist
cd tv && ./gradlew testDebugUnitTest assembleDebugpassescd client && npm run lint && npm run buildpasses