Repository navigation
Add first-run onboarding to the TV app - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TV app now opens a three-step setup on first launch instead of dropping straight into settings: welcome, overlay permission, test card. The permission step can be skipped, and when it is, every later screen states that TibeePost is unusable until the permission is granted.
Changes
Add first-run onboarding flow: newui/onboardingpackage (OnboardingScreen,WelcomeStep,PermissionStep,TestStep,DoneStep,UnusableWarning,OnboardingStep), anonboarding_donepreference, andMainActivityshowing the setup until it is finished. The permission step opens the system page when the TV has one, shows the adb command otherwise, and advances by itself when the permission flips to granted while displayed. The test step posts a real notification through the local server. The overlay-permission panel on the settings screen now reads "TibeePost is unusable until this permission is granted".Let settings relaunch the setup flow: "Run setup again" row at the bottom of the settings list.Document the first-run setup flow: README section describing the steps and the relaunch row.No version change; the next release tag sets
versionName.Testing
./gradlew assembleDebug testDebugUnitTest lintDebug: builds, 57 tests pass, 0 lint errors.SettingsStatefor both screens. Please try the first launch on the CHiQ and report anything the D-pad cannot reach.Checklist
cd tv && ./gradlew testDebugUnitTest assembleDebugpassescd client && npm run lint && npm run buildpasses (client untouched)