docs: Add warning to changes in board variants in zephyr 4.1#3298
Open
Ndot wants to merge 1 commit intozmkfirmware:mainfrom
Open
docs: Add warning to changes in board variants in zephyr 4.1#3298Ndot wants to merge 1 commit intozmkfirmware:mainfrom
Ndot wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
Comment on lines
+72
to
+73
| Since Zephyr 4.1 the argument `-b` needs to be set according to the new board | ||
| variants. E.g. instead of `planck_rev6` it should be `planck//zmk`. Read more about |
Contributor
There was a problem hiding this comment.
Suggested change
| Since Zephyr 4.1 the argument `-b` needs to be set according to the new board | |
| variants. E.g. instead of `planck_rev6` it should be `planck//zmk`. Read more about | |
| Since moving to Zephyr 4.1, the board IDs for boards in ZMK/Zephyr need include the ZMK board | |
| variants. E.g. instead of `planck_rev6` it should be `planck//zmk`. Read more about |
or something like this.
And we should probably fix the -b proton_c a few lines up, while we're at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR check-list
The docs made no reference to the new board variants in zephyr which will end up in failed builds when using Zephyr 4.1. (#3297)
I added a warning calling attention to it in "Local Toolchain/Building and Flashing" page. Although I'm guessing the project is moving on with the new version of zephyr so probably all the examples should be rewritten to reflect the new way to reference boards.