You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ZMK_EXT_POWER_IDLE_OFF (disabled by default) to turn off external power when the keyboard goes into idle, and enable it again when it exits idle. Seems like it would be particularly useful for trackpoint users.
ZMK_IDLE_USB (enabled by default) which enables/disables idling while connected to USB power. I'd be expecting RGB lovers to request this.
First flag is tested and confirmed working. Unable to test second flag, implementation is trivial though. Unable to test whether the display re-init bug mentioned in #1300 is still present, would expect this to interact poorly if so.
I think the combination of the two settings is overlapping with CONFIG_ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE. I think it could be nice to make the handling more structured by directly tying the behavior to power states, then configure the state's general behavior as with proposed settings. However it does reduce flexibility when you have multiple peripherals and want different behavior.
There is some ideological overlap, but currently no functional overlap: CONFIG_ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE merely turns brightness down to 0. There is use case for both currently - for example if the peripheral of a split is powered from the central and doesn't have its own battery, with a bit of underglow added on.
How this would look in the future when we have proper PM support I'm less certain about.
Going to close this for the time being - on further thinking, I think I'd rather revisit this once #1775 is merged and see if it's still a good thing to have then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreCore functionality/behavior of ZMKenhancementNew feature or request
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two Kconfig flags:
ZMK_EXT_POWER_IDLE_OFF(disabled by default) to turn off external power when the keyboard goes into idle, and enable it again when it exits idle. Seems like it would be particularly useful for trackpoint users.ZMK_IDLE_USB(enabled by default) which enables/disables idling while connected to USB power. I'd be expecting RGB lovers to request this.First flag is tested and confirmed working. Unable to test second flag, implementation is trivial though. Unable to test whether the display re-init bug mentioned in #1300 is still present, would expect this to interact poorly if so.