refactor(Hash): store raw digest bytes in arrays#15
Open
selfisekai wants to merge 6 commits intozkat:latestfrom
Open
refactor(Hash): store raw digest bytes in arrays#15selfisekai wants to merge 6 commits intozkat:latestfrom
selfisekai wants to merge 6 commits intozkat:latestfrom
Conversation
BREAKING CHANGE: new type signature of Hash, digest lengths are now validated Fixes: zkat#5
selfisekai
commented
Dec 5, 2024
Owner
|
This is a pretty big, API-visible breaking change. While the refactor does seem nicer, do you have benchmark numbers on what difference they might make? The difference would need to be noticeable in order to justify this, imo. |
Author
|
No, my focus was on correctness. Seems to be less than statistical error on a quick check. Added new APIs for convenience. I think all API breakages have an easy migration path now:
|
Owner
|
I'm gonna sit on this for a bit. ssri has been fairly stable for a while and if I'm gonna put out a breaking change, I'd like to have more substantial stuff bundled with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: new type signature of Hash, digest lengths are now validated
Fixes: #5