Move capture 2D trigger node to samples - #159
Open
snw1317 wants to merge 8 commits into
Open
Conversation
Contributor
|
Thank you for the contribution @snw1317! I think this service should rather be put in |
Author
|
Of course! |
Author
|
I went ahead and updated this. Let me know if you want any more changes. |
Member
Thanks for your contribution, your change is not formatted correctly https://github.com/zivid/zivid-ros/actions/runs/27603712568/job/81610556925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capture_2d_triggernode fromzivid_cameraintozivid_samples, matching maintainer feedback that this functionality belongs as a sample.capture_2d_triggerwhile changing launch files to run it fromzivid_samples.auto_capture_2d,capture_2d_rate,capture_2d_wait_for_service_timeout_s, andsettings_2d_*.masterthrough v3.3.0 and fix invalid launch XML descriptions by escaping<=as<=.Testing
xmllint --noout zivid_samples/launch/*.launchgit diff --checkcolcon build --packages-up-to zivid_camera zivid_sampleswas attempted, but this WSL machine does not have Zivid Core installed, so CMake cannot findZividConfig.cmake.