Skip to content

Move capture 2D trigger node to samples - #159

Open
snw1317 wants to merge 8 commits into
zivid:masterfrom
snw1317:master
Open

Move capture 2D trigger node to samples#159
snw1317 wants to merge 8 commits into
zivid:masterfrom
snw1317:master

Conversation

@snw1317

@snw1317 snw1317 commented Jan 24, 2026

Copy link
Copy Markdown

Summary

  • Move the capture_2d_trigger node from zivid_camera into zivid_samples, matching maintainer feedback that this functionality belongs as a sample.
  • Keep the executable name as capture_2d_trigger while changing launch files to run it from zivid_samples.
  • Preserve the existing auto-capture launch parameters: auto_capture_2d, capture_2d_rate, capture_2d_wait_for_service_timeout_s, and settings_2d_*.
  • Sync with upstream master through v3.3.0 and fix invalid launch XML descriptions by escaping <= as &lt;=.

Testing

  • xmllint --noout zivid_samples/launch/*.launch
  • git diff --check
  • Local colcon build --packages-up-to zivid_camera zivid_samples was attempted, but this WSL machine does not have Zivid Core installed, so CMake cannot find ZividConfig.cmake.

@johningve

Copy link
Copy Markdown
Contributor

Thank you for the contribution @snw1317!

I think this service should rather be put in zivid_samples. I'd be happy to take over the PR to get it merged as a sample.

@snw1317

snw1317 commented Feb 6, 2026

Copy link
Copy Markdown
Author

Of course!
Makes sense. Sure that works for me.

@snw1317 snw1317 changed the title Capture 2D Trigger Node Move capture 2D trigger node to samples May 11, 2026
@snw1317

snw1317 commented May 11, 2026

Copy link
Copy Markdown
Author

I went ahead and updated this. Let me know if you want any more changes.

@RMPR

RMPR commented Jun 16, 2026

Copy link
Copy Markdown
Member

I went ahead and updated this. Let me know if you want any more changes.

Thanks for your contribution, your change is not formatted correctly https://github.com/zivid/zivid-ros/actions/runs/27603712568/job/81610556925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants