Add ability to estimate intrinsics from frame - #154
Open
torbsorb wants to merge 1 commit into
Open
Conversation
Add the parameter `intrinsics_source` to control how the intrinsics are determined. Add a new sample to demonstrate intrinsics and the new parameter. See README.md and [Camera Intrinsics](https://support.zivid.com/en/latest/reference-articles/camera-intrinsics.html#which-camera-intrinsics-should-i-use) for more information.
| { | ||
| case IntrinsicsSource::Camera: | ||
| ROS_INFO("Using camera intrinsics for publishing images"); | ||
| return Zivid::Experimental::Calibration::intrinsics(camera_, frame.settings()); |
Collaborator
There was a problem hiding this comment.
This code doesn't take into account that the settings could have a different 2D vs 3D resolution. On the ROS2 branch, I made a function to check first if 2D settings are defined, and if so uses that instead of the 3D settings: https://github.com/zivid/zivid-ros/pull/153/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the parameter
intrinsics_sourceto control how the intrinsics are determined.Add a new sample to demonstrate intrinsics and the new parameter.
See README.md and
Camera Intrinsics for more information.