Skip to content

getHistoricalData of KiteConnect class was not using the interface for its params defined in /interfaces #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shibisuriya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

getHistoricalData of KiteConnect class was not using the interface for its params defined in /interfaces #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions interfaces/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,13 +462,13 @@ export interface Order {
* This interface defines the parameters required to retrieve historical data.
*
* @public
* @name getHistoricalDataParams
* @name GetHistoricalDataParams
*/
export interface getHistoricalDataParms {
export interface GetHistoricalDataParams {
/**
* @type {string}
*/
instrument_token: string;
instrument_token: string | number;
/**
* @type {string}
*/
Expand All @@ -484,11 +484,11 @@ export interface getHistoricalDataParms {
/**
* @type {?boolean}
*/
continuous?: boolean;
continuous?: boolean | number;
/**
* @type {?boolean}
*/
oi?: boolean;
oi?: number | boolean;
};

/**
Expand Down
9 changes: 7 additions & 2 deletions lib/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import csvParse from 'papaparse';
import sha256 from 'crypto-js/sha256';
import qs from 'qs';
import utils from './utils';
import { KiteConnectParams, Varieties, GTTStatusTypes, AnyObject, Order, MarginOrder, VirtualContractParam, TransactionTypes, KiteConnectInterface, CancelOrderParams, ExitOrderParams, ModifyGTTParams, ModifyOrderParams, PlaceGTTParams, PlaceMFOrderParams, PlaceOrderParams, ConvertPositionParams, Exchanges } from '../interfaces';
import { KiteConnectParams, Varieties, GTTStatusTypes, AnyObject, Order, MarginOrder, VirtualContractParam, TransactionTypes, KiteConnectInterface, CancelOrderParams, ExitOrderParams, ModifyGTTParams, ModifyOrderParams, PlaceGTTParams, PlaceMFOrderParams, PlaceOrderParams, ConvertPositionParams, Exchanges, GetHistoricalDataParams } from '../interfaces';
import { DEFAULTS, ROUTES } from '../constants';


Expand Down Expand Up @@ -697,7 +697,12 @@ export class KiteConnect implements KiteConnectInterface {
* @param {(number | boolean)} [oi=false]
* @returns {Promise<any>}
*/
getHistoricalData(instrument_token: number | string, interval: string, from_date: string | Date, to_date: string | Date, continuous: number | boolean = false, oi: number | boolean = false) {
getHistoricalData(instrument_token: GetHistoricalDataParams['instrument_token'],
interval: GetHistoricalDataParams['interval'],
from_date: GetHistoricalDataParams['from_date'],
to_date: GetHistoricalDataParams['to_date'],
continuous: GetHistoricalDataParams['continuous'] = false,
oi: GetHistoricalDataParams['oi'] = false) {
continuous = continuous ? 1 : 0;
oi = oi ? 1 : 0;
if (typeof to_date === 'object') to_date = _getDateTimeString(to_date)
Expand Down