Conversation
knadh
force-pushed
the
pkg
branch
2 times, most recently
from
f20f7cb to
c5e6fb7
Compare
…ackages. Context: To build services that can consume from Kafka sources and transform+write to arbitrary downstreams like Redis, not just Kafka. This patch doesn't break any existing functionality in the kaf-relay daemon. It refactors /internal packages to make them resuable and the hardcoded target/writer now becomes an interface implementation of the generic `Writer` interface. New packages are: - pkg/kafkawriter - pkg/relay All reusable interface definitions are in: - pkg/relay/writer.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: To build services that can consume from Kafka sources and transform+write to arbitrary downstreams like Redis, not just Kafka.
This patch doesn't break any existing functionality in the kaf-relay daemon. It refactors /internal packages to make them resuable and the hardcoded target/writer now becomes an interface implementation of the generic
Writerinterface.New packages are:
All reusable interface definitions are in: