Draft
Verify multi-site id honor in MCP .wsb channel; document cross-repo root cause of duplicate/first-only launch#5
Conversation
|
|
Copilot
AI
changed the title
[WIP] Fix multiple banks opening issue and prevent duplicate sites
Verify multi-site id honor in MCP .wsb channel; document cross-repo root cause of duplicate/first-only launch
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When asked to launch multiple banks (
kb 국민은행과 우리은행 인터넷 뱅킹을 실행하려 해.), only the first bank opens, and in Spork command-line mode the site opens twice. This traces the multi-argument path MCP → tablecloth-prepare.ps1 → SporkBootstrap → Spork.exe and pins the failure downstream.Findings
Tools/SandboxTools.cs(BuildWsb) andnode/src/tools/sandbox-tools.ts(buildWsb) emit every id, space-joined, in a single assignment:TableCloth/tools/no-install/tablecloth-prepare.ps1:Start-Process $launcher -ArgumentList @('--site-ids', $SiteIds)flattens the value into separate argv tokens (reproduced withpwsh), andSpork.Bootstrapper/BootstrapOptions.cs(case "--site-ids": siteIds = value) keeps only the first — the rest are dropped.main(removedOpenWebSiteStepfromStepsComposer), pending release. With one id surviving, that single site is opened twice by the older runner — the same underlying behavior.Changes
node/test/conformance.mjs— added agenerate_wsb(["Hometax","ShinhanBank"])regression check asserting both builds keep all ids, in a singleTABLECLOTH_SITE_IDSassignment, space-joined, byte-identical across .NET/Node.SPEC.md§7 — documented the multi-id honor contract (all ids preselected, assigned once; each site opened once end-to-end).TROUBLESHOOTING.md— Known-issue entry: MCP boundary is correct; exact downstream root causes and fixes.Scope
The MCP's half of the path is correct and now regression-tested. The runtime fix (preserve all ids when forwarding
--site-ids; keep the landed single-open fix) belongs to theyourtablecloth/TableClothrunner/prepare script and its next release, outside this repository.