This repository was archived by the owner on Mar 16, 2023. It is now read-only.
Don't crash on "class << A; self; end" #200
Open
mvidner wants to merge 3 commits intoyorickpeterse:masterfrom
Open
Don't crash on "class << A; self; end" #200mvidner wants to merge 3 commits intoyorickpeterse:masterfrom
mvidner wants to merge 3 commits intoyorickpeterse:masterfrom
Conversation
by calling define_self in on_sclass This occurs in bundler-1.12.6
mvidner
force-pushed
the
self-in-sclass
branch
from
2126db5 to
6265367
Compare
Contributor
Author
|
Note that the crash occurs only if the named class is not known. That is, class A; end
class << A; self; endwould be processed just fine. In the concrete case of bundler, the problematic source is source_index_class = (class << Gem::SourceIndex; self; end)which concerns an older version of rubygems that is not described in ruby-lint/definitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing this makes it possible to analyze bundler-1.12.6