Repository navigation
Conversation
Actions without a kind still need the separator to keep the server column aligned with the actions that have one.
Contributor
Author
|
I don't understand why the unit test is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Actions without a kind still need the separator to keep the server column aligned with the actions that have one. The previous implementation in #802 left it out, so the server tag of a kind-less action started one column too early.
🔍 Related Issues
🧪 What This PR Improves
When a menu mixes actions with and without a kind, the rows without one are missing the space between the kind column and the server tag, while the padding still reserves the kind column. The server column ends up misaligned by one character:
With this change all server tags start in the same column. Rows that have a kind are rendered exactly as before.
🛠️ Changes Made
longest.kind > 0), not only when the action itself has a kind.[quickfix]action and server names of different widths🧪 Testing
Test_CodeActionMenuMetadatapasses with the fix, including all existing layouts (short,kind,full-kind,server,kind-and-server,full-kind-and-server).📦 Breaking Changes
Does this PR introduce any breaking changes?
📚 Documentation
Does this PR require documentation updates?
✔️ Checklist