Repository navigation
Conversation
When diagnostics arrive for an unloaded buffer, its line count is 1, so the start line of every diagnostic was clamped to the first line while the end line was kept. Once the buffer was loaded, the inline highlight spanned from line 1 to the end of the diagnostic. Load the buffer before reading its line count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
When diagnostics arrive for an unloaded buffer, its line count is 1, so the start line of every diagnostic was clamped to the first line while the end line was kept. Once the buffer was loaded, the inline highlight spanned from line 1 to the end of the diagnostic. Load the buffer before reading its line count.
🔍 Related Issues
None
🧪 What This PR Improves
Fixes a bug that sporadically happened for me in clangd.
🛠️ Changes Made
Loading the buffer before reading its line count. There was already a Todo there.
🧪 Testing
Repro:
repro.c
repro.h
Steps:
vim repro.cand wait for clangd to load:e repro.hand remove the semicolon at the end of the function declaration to make clangd show and error. Save with:w.:b repro.c📦 Breaking Changes
Does this PR introduce any breaking changes?
📚 Documentation
Does this PR require documentation updates?
If yes, describe what needs updating.
✔️ Checklist