Skip to content

fix(ci): Add pipx-packages to deps image workflow trigger paths.#1869

Merged
Bill-hbrhbr merged 9 commits into
y-scope:mainfrom
Bill-hbrhbr:add-pipx-package-workflow-trigger
Jan 19, 2026
Merged

fix(ci): Add pipx-packages to deps image workflow trigger paths.#1869
Bill-hbrhbr merged 9 commits into
y-scope:mainfrom
Bill-hbrhbr:add-pipx-package-workflow-trigger

Conversation

@Bill-hbrhbr
Copy link
Copy Markdown
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Jan 14, 2026

Description

#1271 introduced pipx package install scripts under components/core/tools/scripts/lib_install/pipx-packages/, but the deps image GitHub Actions workflow was not updated to watch this directory. As a result, changes to these scripts would not trigger the expected image rebuilds.

This PR adds the missing path to the workflow trigger list and includes a small refactor to eliminate duplicated config path definitions.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Workflows are picked up by GitHub CI and execute successfully.

Summary by CodeRabbit

  • Chores
    • Centralized and simplified CI workflow path rules by introducing shared path groups and replacing duplicated lists.
    • Unified pull-request and push trigger behavior across pipelines.
    • Removed several macOS-specific monitored paths and replaced them with a consolidated package-related path set.

✏️ Tip: You can customize this high-level summary in your review settings.

@Bill-hbrhbr Bill-hbrhbr requested a review from a team as a code owner January 14, 2026 21:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 14, 2026

Walkthrough

Consolidates path trigger definitions in two GitHub Actions workflows: adds a shared path group in the artifact-build workflow and a YAML anchor in the macOS core-build workflow; both include components/core/tools/scripts/lib_install/pipx-packages/** and adjust monitored paths for push and pull_request events.

Changes

Cohort / File(s) Change Summary
Artifact build workflow
​.github/workflows/clp-artifact-build.yaml
Added shared filter group _deps_images_common_paths and included components/core/tools/scripts/lib_install/pipx-packages/**. Replaced per-image explicit path lists by referencing the shared group for centos_stream_9_image, manylinux_2_28_x86_64_image, musllinux_1_2_x86_64_image, and ubuntu_jammy_image; retained image-specific docker/script paths.
macOS core build workflow
​.github/workflows/clp-core-build-macos.yaml
Introduced a YAML anchor (monitored_paths) reused for both pull_request.paths and push.paths. Removed several previously monitored PR paths (including macOS-specific lib_install and various scripts/taskfiles) and replaced the macOS lib_install entry with components/core/tools/scripts/lib_install/pipx-packages/**.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding pipx-packages directory to workflow trigger paths for deps image builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look correct to me. posted some nitpicky comments

Comment thread .github/workflows/clp-core-build-macos.yaml Outdated
Comment thread .github/workflows/clp-core-build-macos.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Copy link
Copy Markdown
Member

@junhaoliao junhaoliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the title, how about:

fix(ci): Add `pipx-packages` to deps image workflow trigger paths.

@Bill-hbrhbr Bill-hbrhbr changed the title fix(ci): Update deps image workflows to track pipx-packages scripts' changes. fix(ci): Add pipx-packages to deps image workflow trigger paths. Jan 19, 2026
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
Comment thread .github/workflows/clp-artifact-build.yaml Outdated
@Bill-hbrhbr
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 19, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@junhaoliao junhaoliao self-assigned this Jan 19, 2026
@junhaoliao junhaoliao added this to the Backlog milestone Jan 19, 2026
@Bill-hbrhbr Bill-hbrhbr merged commit 3e4c192 into y-scope:main Jan 19, 2026
25 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the add-pipx-package-workflow-trigger branch January 19, 2026 06:38
@junhaoliao junhaoliao removed this from the Backlog milestone Jan 20, 2026
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants