Skip to content

feat(integration-tests): Add fixtures and tests for starting and stopping CLP packages.#1437

Merged
quinntaylormitchell merged 64 commits into
y-scope:mainfrom
quinntaylormitchell:testing-start-stop
Dec 2, 2025
Merged

feat(integration-tests): Add fixtures and tests for starting and stopping CLP packages.#1437
quinntaylormitchell merged 64 commits into
y-scope:mainfrom
quinntaylormitchell:testing-start-stop

Conversation

@quinntaylormitchell
Copy link
Copy Markdown
Collaborator

@quinntaylormitchell quinntaylormitchell commented Oct 17, 2025

Description

This PR builds on the infrastructure introduced in PR #1100 and PR #1549 by introducing a parametrized test called test_clp_package that ensures two key configurations of the clp package (clp-text and clp-json) spin up and tear down successfully. test_clp_package uses the contents of a dictionary called CLP_MODE_CONFIGS to spin up each mode in its proper configuration.

Dependent PRs

This is a foundational infra PR, and so there are other PRs which depend on this one. They are listed below:

Compression PRs

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Ran the following command from clp/integration-tests:

uv run pytest -m 'package'

Both the clp-json and clp-text tests passed.

Summary by CodeRabbit

  • Tests

    • Added integration tests to validate package startup across multiple modes, parameterized via fixtures.
    • New fixtures manage package configuration, lifecycle and cleanup; setup/teardown starts/stops the package and removes temporary config files.
    • Added mode utilities and helpers; improved command execution logging, timeout handling and file-existence validation.
  • Chores

    • Pytest configured to report all outcomes and a new "package" test marker added.
    • Added YAML-related dev dependencies for test config handling.

✏️ Tip: You can customize this high-level summary in your review settings.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants