Bump the bundled SQLite to 3.53.4 - #197
Merged
Merged
Conversation
The bundled amalgamation was 3.33.0, released in August 2020. It is replaced here with 3.53.4, taken from sqlite.org and checked against the SHA3-256 published alongside it. Only the two vendored files change; nothing in the build or the library is touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled amalgamation in
ext/sqlite-amalgamationwas 3.33.0, released in August 2020. This replaces it with 3.53.4.The files were taken from sqlite.org and checked against the SHA3-256 published alongside them (
628a44cfe82c66aed1ccbbe85a562d2e33ebe64b3288981ed76285612227934eforsqlite-amalgamation-3530400.zip).Only the two vendored files change; nothing in the build or the library is touched.
Why
Split out of #196, where it matters for a specific reason: reading an encrypted OneLibrary database goes through
sqlite3_deserialize, which arrived in SQLite 3.36. Built with-DSYSTEM_SQLITE=OFFagainst 3.33, that library compiles and passes its tests and then refuses to open any such database at run time. It is useful on its own, though, so it is offered separately rather than buried in that branch.Testing
Built and run on macOS (arm64, Apple clang) with both
-DSYSTEM_SQLITE=ONand-DSYSTEM_SQLITE=OFF: clean build under the project's-Wall -Wpedantic -Werror, 12/12 tests passing in each.The amalgamation was also compiled by GCC 12 on x86-64 under the same warning flags, since a newer SQLite is the sort of thing that can introduce warnings; it was clean there too.
One consequence worth noting: the amalgamation has grown from 8.1 MB to 9.5 MB, and compiling it takes about 15 seconds rather than 11 on the machine used above.