feat(i13-1): scaffold Diamond I13-1 (I13 coherence branch) deployment, the fleet's first coherent lensless imaging (ptychography / CDI), reverse-engineered and deliberately partial#398
Merged
Conversation
…, the fleet's first coherent lensless imaging (ptychography / CDI), reverse-engineered and deliberately partial I13-1 is the coherence branch of Diamond's I13 (Hard X-ray Imaging and Coherence) and CORA's FIRST coherent lensless-imaging deployment: hard X-ray ptychography and coherent diffraction imaging (raster a coherent beam across the sample, capture the far-field coherent diffraction, reconstruct a real-space image downstream). The fleet has tomography, an XRF microprobe, and a hard X-ray nanoprobe, but no ptychography / CDI. Reverse-engineered from DiamondLightSource/dodal (src/dodal/beamlines/i13_1.py), the 10th Diamond beamline. DELIBERATELY PARTIAL (the I20-1 posture). The dodal i13_1 module exposes only the coherence-branch endstation: a piezo sample-scanning stage, a side viewing camera, and the Merlin coherent-diffraction detector. The shared I13 source and optics (undulator, monochromator, mirrors, slits) are upstream and not in the module, so they are deferred, not invented (SRC-1, OPT-1). EPICS PVs (the BL13J prefix) are real, carried confirm. WHY zero new families. The novelty is an acquisition shape plus a reconstruction, i.e. a Method, NOT a device class: the devices the technique needs are a sample-scanning stage and area detectors, both already in the catalog. The scout that surfaced I13-1 anticipated a new "coherent imaging" device family; that is the wrong axis (the same over-prediction the eval corrected for i19's four-circle). So the PI piezo sample-scanning stage binds LinearStage (the ptychography raster is its operative motion; the fixed-angle lab-frame variant on BL13J-MO-PI-02:FIXANG: is a setting on the same stage), the Merlin (Medipix3) photon-counting detector and the Aravis side viewing camera bind Camera, and the machine state binds the loose StorageRing. Ptychography / CDI is carried as a new pending Method (the fleet's first coherent diffractive imaging); the image reconstruction from the diffraction stack is ComputePort work, not a beamline device (TECH-1). Zero new families, nothing graduates, the catalog is unchanged. Wiring: I13-1 added to the Diamond Site beamline list with a ptychography Practice; the new pending ptychography method added to the registry; mkdocs nav block. Gate: 410 deployment tests pass, mkdocs --strict builds clean, adversarial per-doc verify (generated-page list pre-fed: three wrong-depth cross-references fixed, a Detector / Controls / Merlin link pointing at the generated beamline.md instead of the equipment pages; no invention, the deferred shared source / optics confirmed absent not fabricated). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
xmap
added a commit
that referenced
this pull request
Jun 26, 2026
Resolve the append-only conflicts (NSLS-II beamline list, mkdocs nav, deployments index row, the FlowController/BeamPositionMonitor promotion-review notes) against the current main, which has advanced to ISR (#399). Reconcile CDI against i13-1 (#398, merged after CDI was opened): i13-1 is the fleet's first coherent diffractive imaging and coined the pending ptychography Method. CDI no longer claims "first"; it is the second coherent-imaging deployment and the first at NSLS-II / first full source-to-detector one, reinforcing i13-1's pending ptychography Method (ptychography reuses it; forward / Bragg CDI are its single-shot variants, not separately coined). No Practice recorded (CHX discipline). Gate: 424 deployment tests pass, mkdocs --strict clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scaffolds Diamond I13-1 (the coherence branch of I13), CORA's first coherent lensless-imaging deployment: hard X-ray ptychography / coherent diffraction imaging (raster a coherent beam, capture far-field diffraction, reconstruct downstream). The fleet had tomography, an XRF microprobe, and a hard X-ray nanoprobe, but no ptychography / CDI. Reverse-engineered from dodal (
src/dodal/beamlines/i13_1.py), the 10th Diamond beamline.Deliberately partial (the I20-1 posture)
The dodal
i13_1module exposes only the coherence-branch endstation — a piezo sample stage, a side viewing camera, and the Merlin detector. The shared I13 source and optics (undulator, mono, mirrors, slits) are upstream and not in the module, so they are deferred, not invented (SRC-1,OPT-1). EPICS PVs (theBL13Jprefix) are real, carriedconfirm.Why zero new families
The novelty is an acquisition shape + reconstruction, i.e. a Method, not a device class — the devices the technique needs (a sample-scanning stage, area detectors) are already in the catalog. The scout anticipated a new "coherent imaging" device family; that's the wrong axis (the same over-prediction the eval corrected for i19's four-circle). So:
LinearStage(the ptychography raster; the fixed-angle variant is a setting on the same stage)CameraStorageRingComputePortwork, not a device (TECH-1)Zero new families, nothing graduates, the catalog is unchanged.
Gate
mkdocs --strictbuilds cleanbeamline.mdinstead of the equipment pages); no invention — the deferred shared source/optics confirmed absent, not fabricated🤖 Generated with Claude Code