fix: handle deferred game database loading in library sidebar#572
Merged
ximu3 merged 1 commit intoximu3:mainfrom May 3, 2026
Merged
fix: handle deferred game database loading in library sidebar#572ximu3 merged 1 commit intoximu3:mainfrom
ximu3 merged 1 commit intoximu3:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a loading state to the Library sidebar so the game list UI is deferred until the background (phase 2) game database load completes, addressing the startup case where the list appears empty/not loaded.
Changes:
- Subscribe to
gamesLoadedfromuseGameRegistryand gateLibrarybarrendering on it. - Show a spinner + localized “Loading games…” message while games are still loading.
- Add
react-i18nexttranslation usage for the loading message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复程序启动后游戏列表不加载的问题。
该问题与 #551 引入的数据库分阶段加载相关,其虽然在主页的内容显示区订阅了加载完成状态,但是左侧的游戏列表没有订阅该状态,导致数据库加载完成后列表没有重新渲染。
较为有趣的是,在开发模式下使用大规模的游戏数据库未能复现该问题,推测可能是某处未知的状态更新触发了列表的重渲染;换为规模较小的游戏数据库才成功复现。
Fix #576