Add support for python3#1
Merged
Merged
Conversation
added 3 commits
February 20, 2024 20:14
The result of running: futurize -w sfftp xsautowf xscertparser xsjira
system info is now exported as a string rather than printing to the screen.
It's an array that has been appended to since it was introduced in 2563a0b and has never been used. Remove the dead code.
JaviMerino
force-pushed
the
py3_conversion
branch
from
a09a902 to
32e04ac
Compare
stephenchengCloud
approved these changes
Feb 21, 2024
catherineliuchina
approved these changes
May 8, 2024
Collaborator
By the way, the fomal repo of python-hwinfo is https://github.com/xenserver/python-hwinfo, and it's already in Python3. |
Author
I was fetching python-hwinfo from the wrong place. Thanks for letting me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for python3, so that the ack-results-parser can be used with python2 or python3
python-hwinfo can't be used from pypi because it is python2 only. This package depends on this pull request in
python-hwinfo: rdobson/python-hwinfo#25 , which adds python3 support topython-hwinfo.