Skip to content

update to visualization API 4.1.0 and code cleanups#78

Open
AlwinEsch wants to merge 6 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change
Open

update to visualization API 4.1.0 and code cleanups#78
AlwinEsch wants to merge 6 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change

Conversation

@AlwinEsch
Copy link
Copy Markdown
Member

@AlwinEsch AlwinEsch commented May 19, 2026

Add-on update related to Kodi API change defined on xbmc/xbmc#28278

Further done minor code cleanups.

Runtime tests on Windows and Linux are OK.

@kodiai
Copy link
Copy Markdown

kodiai Bot commented May 19, 2026

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 9 changed files.
Review Details
  • Review plan: ready hash=f129e5bb022d route=standard task=review.full files=9 lines=882(local-diff) budget=50t/664s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred

  • Review reducer: ready input=0 kept=0 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0

  • Review candidates: shadow recorded=0 rejected=0 errors=0 artifact=absent repo=xbmc-visualization.matrix pr=78 key=kodiai-review-output:v1:inst-109141824:xbmc-visualization.matrix:pr-78:action-op delivery=2ade8c90-5316-11f1-9901-e8ee72a676e0

  • Review candidate publication: mode=blocked approved=0 rewritten=0 published=0 directFallback=0 reasons=no-candidate-publication-path,approval-blocked

  • Files reviewed: 9

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +571 -311

  • Profile: minimal (auto, lines changed: 882)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=98ec5a861959c910 deliveryId=2ade8c90-5316-11f1-9901-e8ee72a… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:7b560d7112f173183947be72b4654568; recordKey=candidate-publication-record:7b560d7112f173183947be72b4654568; correlationKey=candidate-publication-bridge:c16b1fe4582a2ad3eec109e85bc6f0fa; source=review-handler-publication; candidateRef=candidate-publication-summary-00af1dde; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review completed: 2026-05-19T00:08:09.167Z

  • Total wall-clock: 4m 38s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 819ms
    • retrieval/context assembly: 2.4s
    • executor handoff: 8.6s
    • remote runtime: 4m 21s
    • publication: 2.9s
  • Tokens: 68 in / 11,731 out | 0.3992

  • Keyword parsing: No keywords detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant