Skip to content

Consolidate open dependabot dependency bumps - #10603

Open
pavinduLakshan wants to merge 3 commits into
masterfrom
consolidate-dependabot-updates
Open

pavinduLakshan wants to merge 3 commits into
masterfrom
consolidate-dependabot-updates

Conversation

@pavinduLakshan

Copy link
Copy Markdown
Member

Summary

Consolidates the following open dependabot PRs into a single PR to reduce review overhead:

npm/yarn

Maven

Several of these are major version bumps (vite, fast-xml-parser, simple-git, jackson-databind, tomcat-catalina) with potential breaking changes that should be verified in CI/manual testing before merge.

Test plan

  • CI build passes for all affected apps/modules
  • pnpm install resolves cleanly and pnpm typecheck passes
  • Maven build passes for apps/console/java, apps/myaccount/java, identity-apps-core
  • Manual smoke test of console and myaccount apps (vite major bump)

🤖 Generated with Claude Code

Merges the version bumps from PRs #10600, #10585, #10584, #10583, #10582,
#10575, #10574, #10573, #10561, #10560, #10559, #10556, #10491, #10483,
#10462, #10432, #10421, #10410, #10408 into one changeset to reduce
review overhead of reviewing 19 separate one-line dependency bump PRs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8829aaaa-ea23-4f46-847a-642106237401

📥 Commits

Reviewing files that changed from the base of the PR and between 1bdced4 and 4a31a6c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (9)
  • .changeset/dependency-bumps-consolidation.md
  • apps/console/java/pom.xml
  • apps/console/vite.config.ts
  • apps/myaccount/java/pom.xml
  • apps/myaccount/vite.config.ts
  • identity-apps-core/pom.xml
  • modules/validation/src/validation.ts
  • package.json
  • scripts/update-version.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • .changeset/dependency-bumps-consolidation.md

📝 Walkthrough

Walkthrough

Changes

The pull request consolidates Java and JavaScript dependency upgrades, updates compatibility code for newer tooling APIs, improves image URL header handling, adds workspace dependency overrides, and records patch releases for four packages.

Dependency version consolidation

Layer / File(s) Summary
Java dependency updates
apps/console/java/pom.xml, apps/myaccount/java/pom.xml, identity-apps-core/pom.xml, .changeset/dependency-bumps-consolidation.md
Jackson and Tomcat Catalina versions are updated in both Java applications. Apache CXF is updated to version 3.6.11, and the compatible CXF 3.x constraint is documented.
JavaScript dependency updates
apps/console/package.json, apps/myaccount/package.json, features/admin.copilot.v1/package.json, modules/core/package.json, package.json, pnpm-workspace.yaml, .changeset/dependency-bumps-consolidation.md
Vite, Axios, js-yaml, Storybook, fast-xml-parser, and simple-git versions are updated. Workspace overrides are added or updated for Axios, Babel, DOMPurIFY, Joi, immutable, and lodash.
Tooling compatibility and validation
apps/console/vite.config.ts, apps/myaccount/vite.config.ts, scripts/update-version.js, modules/validation/src/validation.ts
SCSS deprecation settings use explicit tuple types. The version script uses current XMLParser and simpleGit APIs. imageUrl handles an absent content-type header safely.
Workspace release metadata
.changeset/dependency-bumps-consolidation.md
Patch releases are recorded for @wso2is/console, @wso2is/myaccount, @wso2is/core, and @wso2is/admin.copilot.v1.
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Most updates are present, but CXF, console Jackson Core, and MyAccount Jackson Databind do not match issues #10600, #10560, and #10462. Set CXF to 4.1.7, console Jackson Core to 2.18.8, and MyAccount Jackson Databind to 2.22.0, or update the issues with approved targets.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the consolidation of dependency updates.
Description check ✅ Passed The description explains the consolidation, lists linked updates, and provides a relevant test plan, so it is mostly complete.
Out of Scope Changes check ✅ Passed The configuration, validation, and script changes support compatibility with the dependency upgrades and remain within the stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Changeset Required ✅ Passed The full pull request diff adds .changeset/dependency-bumps-consolidation.md; it is not .changeset/README.md and includes patch entries for the affected WSO2IS packages.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch consolidate-dependabot-updates
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
package.json (1)

108-108: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

Update the version script to use the major-version APIs.

fast-xml-parser now exposes ESM imports; the CommonJS-style require("fast-xml-parser") import can break parsing in Node/build tooling. simple-git is promise-based by default in v3 and no longer needs simple-git/promise; replace it with the current v3 entry point to avoid the legacy path warning.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 108, Update the version script’s dependency imports to
use the current major-version APIs: replace the CommonJS require of
fast-xml-parser with its ESM-compatible import, and replace simple-git/promise
with the standard simple-git entry point. Preserve the existing parsing and Git
behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/console/java/pom.xml`:
- Around line 578-580: The Jackson dependency-management entries in
apps/console/java/pom.xml lines 578-580 and apps/myaccount/java/pom.xml lines
580-580 must use one consistent, tested Jackson version line. Align
jackson-core, jackson-annotations, jackson-databind, and
jackson-jaxrs-json-provider in both POM sections, preserving the existing
dependency keys.

In `@identity-apps-core/pom.xml`:
- Line 836: Align the dependency stack before changing org.apache.cxf.version to
4.1.7: either retain the existing javax.ws.rs-api 2.1.1 and Jersey 1.19.1 by
keeping CXF on its compatible version, or migrate all CXF consumers and managed
APIs from javax/Jersey to the Jakarta EE 10 baseline required by CXF 4.1,
including the JDK 17 requirement.

In `@package.json`:
- Around line 120-121: Update the `@storybook/react-webpack5` dependency to
version 9.1.19 to match the pinned storybook package, refresh the lockfile
accordingly, and run storybook doctor to verify the dependency alignment.

---

Nitpick comments:
In `@package.json`:
- Line 108: Update the version script’s dependency imports to use the current
major-version APIs: replace the CommonJS require of fast-xml-parser with its
ESM-compatible import, and replace simple-git/promise with the standard
simple-git entry point. Preserve the existing parsing and Git behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 21551ab7-a142-4fbd-99e3-233027686465

📥 Commits

Reviewing files that changed from the base of the PR and between d7165e5 and 1bdced4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (10)
  • .changeset/dependency-bumps-consolidation.md
  • apps/console/java/pom.xml
  • apps/console/package.json
  • apps/myaccount/java/pom.xml
  • apps/myaccount/package.json
  • features/admin.copilot.v1/package.json
  • identity-apps-core/pom.xml
  • modules/core/package.json
  • package.json
  • pnpm-workspace.yaml

Comment thread apps/console/java/pom.xml Outdated
Comment thread identity-apps-core/pom.xml Outdated
Comment thread package.json
pavinduLakshan and others added 2 commits August 8, 2026 12:10
- Align jackson-core/annotations/databind/jaxrs-json-provider to 2.18.9
  across apps/console/java and apps/myaccount/java (was an inconsistent
  mix left over from applying each dependabot PR's single-property bump).
- Cap org.apache.cxf at 3.6.11 instead of 4.1.7: CXF 4.x requires the
  jakarta.ws.rs namespace and JDK 17, incompatible with identity-apps-core's
  existing javax.ws.rs-api 2.1.1 / Jersey 1.19.1 / JDK 11 baseline. 3.6.11
  is the latest release still on the javax-compatible line.
- Bump @storybook/react-webpack5 to 9.1.19 to match the storybook bump.
- Migrate scripts/update-version.js off removed/deprecated APIs: use
  fast-xml-parser's XMLParser class instead of the removed top-level
  parse() function, and simple-git's default export instead of the
  deprecated simple-git/promise subpath.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- modules/validation/src/validation.ts: response.headers["content-type"]
  is now typed as AxiosHeaderValue (string | string[] | number | boolean |
  null) instead of string, so .includes() no longer type-checks directly.
  Convert to string first and guard for null/undefined.
- apps/console/vite.config.ts, apps/myaccount/vite.config.ts: vite 6's
  bundled sass types narrowed silenceDeprecations from string[] to
  DeprecationOrId[], which is a subtype "legacy-js-api" widens out of when
  written as a plain array literal. Assert it as a literal tuple instead.

Also found and cleaned up stale node_modules/axios symlinks (leftover
from before the axios override bump) that were pointing multiple feature
packages at the old 1.7.0 install, causing a dual-package-version type
clash across unrelated files. Confirmed via a full nx typecheck run
across all 8 typecheck-configured projects (react-components, forms,
access-control, validation, core, i18n, myaccount, console).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.20%. Comparing base (4b360cb) to head (4a31a6c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
modules/validation/src/validation.ts 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10603      +/-   ##
==========================================
- Coverage   73.46%   73.20%   -0.26%     
==========================================
  Files         471      471              
  Lines       71454    72141     +687     
  Branches      266      266              
==========================================
+ Hits        52492    52813     +321     
- Misses      18855    19325     +470     
+ Partials      107        3     -104     
Files with missing lines Coverage Δ
modules/validation/src/validation.ts 0.63% <0.00%> (+0.63%) ⬆️

... and 344 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant