[4.6.0] Correct the cnf / x5t#S256 example on the Securing APIs with Certificate Bound Access Tokens page. - #11802
Open
hisanhunais wants to merge 1 commit into
Open
[4.6.0] Correct the cnf / x5t#S256 example on the Securing APIs with Certificate Bound Access Tokens page.#11802hisanhunais wants to merge 1 commit into
cnf / x5t#S256 example on the Securing APIs with Certificate Bound Access Tokens page.#11802hisanhunais wants to merge 1 commit into
Conversation
hisanhunais
requested review from
chamilaadhi and
tharikaGitHub
as code owners
August 19, 2026 04:54
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cnf / x5t#S256 example on the Securing APIs with Certificate Bound Access Tokens page.cnf / x5t#S256 example on the Securing APIs with Certificate Bound Access Tokens page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
x5t#S256value as a 64-char hex SHA-256 digest, inside invalid JSON. Per RFC 8705 — which the same page cites —x5t#S256must be the base64url-encoded SHA-256 thumbprint of the DER-encoded client certificate (43 chars), andcnfmust be a JSON object. A spec-compliant validator compares the base64url thumbprint, so the documented hex value would never match a real certificate binding.Changes
cnfsnippet into a valid JSON object.x5t#S256value to its base64url form.Before
"cnf", "{"x5t#S256": "9a0c3570ac7392bee14a408ecb38978852a86d38cbc087feeeeaab2c9a07b9f1"}"
After