Skip to content

Fix: unexpected navigation to Dynamic Endpoints in publisher portal #4761 #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShavinAnjithaAlpha wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix: unexpected navigation to Dynamic Endpoints in publisher portal #4761 #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f5dbd0
fix(publisher): prevent dynamic endpoints screen from opening unexpec…
ShavinAnjithaAlpha Jul 8, 2026
19e3edd
refactor(publisher): extract endpoint implementation type constants
ShavinAnjithaAlpha Jul 15, 2026
2303f4a
refactor(publisher): dedupe endpoint save logic between handleSave …
ShavinAnjithaAlpha Jul 16, 2026
57d4666
Fix tautological endpoint type condition in publisher portal
ShavinAnjithaAlpha Jul 17, 2026
b403028
fix(publisher): chain sequence backend delete and upload requests to …
ShavinAnjithaAlpha Jul 20, 2026
df0fd8e
fix(publisher): avoid redundant Promise.resolve() in sequence backend…
ShavinAnjithaAlpha Jul 30, 2026
a0f909d
Rename useState setter to match state variable naming convention
ShavinAnjithaAlpha Jul 30, 2026
265ffe7
Merge branch 'main' into fix/4761-publisher-mock-ui-fix
ShavinAnjithaAlpha Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions ...her/src/main/webapp/source/src/app/components/Apis/Details/Endpoints/EndpointOverview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ import EndpointSecurity from './GeneralConfiguration/EndpointSecurity';
import Credentials from './AWSLambda/Credentials.jsx';
import ServiceEndpoint from './ServiceEndpoint';
import CustomBackend from './CustomBackend';
import {
ENDPOINT_TYPE_PROTOTYPED,
ENDPOINT_IMPLEMENTATION_TYPE_INLINE,
ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT,
ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS,
} from './endpointConstants';

const PREFIX = 'EndpointOverview';

Expand Down Expand Up @@ -162,11 +168,11 @@ const endpointTypes = [
{ key: 'http', value: 'HTTP/REST Endpoint' },
{ key: 'default', value: 'Dynamic Endpoints' },
{ key: 'address', value: 'HTTP/SOAP Endpoint' },
{ key: 'prototyped', value: 'Prototype Endpoint' },
{ key: 'INLINE', value: 'Mock Implementation' },
{ key: ENDPOINT_TYPE_PROTOTYPED, value: 'Prototype Endpoint' },
{ key: ENDPOINT_IMPLEMENTATION_TYPE_INLINE, value: 'Mock Implementation' },
{ key: 'awslambda', value: 'AWS Lambda' },
{ key: 'service', value: 'Service Endpoint' },
{ key: 'MOCKED_OAS', value: 'Mock Implementation' },
{ key: ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS, value: 'Mock Implementation' },
{ key: 'sequence_backend', value: 'Sequence Backend' },
{ key: 'ws', value: 'Websocket Endpoint' },
];
Expand Down Expand Up @@ -237,12 +243,12 @@ function EndpointOverview(props) {
* */
const getEndpointType = (apiObject) => {
const type = apiObject.endpointConfig && apiObject.endpointConfig.endpoint_type;
if (apiObject.endpointImplementationType === 'INLINE') {
if (apiObject.endpointImplementationType === ENDPOINT_IMPLEMENTATION_TYPE_INLINE) {
return endpointTypes[4];
} else if (apiObject.endpointImplementationType === 'MOCKED_OAS') {
} else if (apiObject.endpointImplementationType === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS) {
return endpointTypes[7];
} else if (apiObject.endpointImplementationType === 'ENDPOINT'
&& apiObject.endpointConfig.implementation_status === 'prototyped'
} else if (apiObject.endpointImplementationType === ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT
&& apiObject.endpointConfig.implementation_status === ENDPOINT_TYPE_PROTOTYPED
&& api.lifeCycleStatus === 'PROTOTYPED') {
return endpointTypes[3];
} else if (type === 'http') {
Expand Down Expand Up @@ -322,7 +328,7 @@ function EndpointOverview(props) {
{ key: 'service', value: 'Service Endpoint' },
{ key: 'address', value: 'HTTP/SOAP Endpoint' },
{ key: 'default', value: 'Dynamic Endpoints' },
{ key: 'INLINE', value: 'Mock Implementation' },
{ key: ENDPOINT_IMPLEMENTATION_TYPE_INLINE, value: 'Mock Implementation' },
{ key: 'awslambda', value: 'AWS Lambda' },
];
}
Expand Down Expand Up @@ -361,7 +367,7 @@ function EndpointOverview(props) {
if (epType.key === 'service') {
getServices();
}
if (epType.key !== 'INLINE' || epType.key !== 'MOCKED_OAS') {
if (epType.key !== ENDPOINT_IMPLEMENTATION_TYPE_INLINE && epType.key !== ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS) {
setEndpointCategory({
prod: !!endpointConfig.production_endpoints,
sandbox: !!endpointConfig.sandbox_endpoints,
Expand Down Expand Up @@ -563,21 +569,21 @@ function EndpointOverview(props) {
setTypeChangeConfirmation({ openDialog: false, serviceInfo: false });
setIsCustomBackendSelected(false);
const selectedKey = typeChangeConfirmation.type || value;
if (selectedKey === 'INLINE' || selectedKey === 'MOCKED_OAS') {
const tmpConfig = createEndpointConfig('prototyped');
if (selectedKey === ENDPOINT_IMPLEMENTATION_TYPE_INLINE || selectedKey === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS) {
const tmpConfig = createEndpointConfig(ENDPOINT_TYPE_PROTOTYPED);
endpointsDispatcher({
action: 'set_inline_or_mocked_oas',
value: {
endpointConfig: tmpConfig,
endpointImplementationType: selectedKey,
},
});
} else if (selectedKey === 'prototyped') {
} else if (selectedKey === ENDPOINT_TYPE_PROTOTYPED) {
const tmpConfig = createEndpointConfig(selectedKey);
endpointsDispatcher({
action: 'set_prototyped',
value: {
endpointImplementationType: 'ENDPOINT',
endpointImplementationType: ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT,
endpointConfig: tmpConfig,
},
});
Expand All @@ -586,7 +592,7 @@ function EndpointOverview(props) {
endpointsDispatcher({
action: 'select_endpoint_type',
value: {
endpointImplementationType: 'ENDPOINT',
endpointImplementationType: ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT,
endpointConfig: { ...generatedEndpointConfig },
},
});
Expand All @@ -596,7 +602,7 @@ function EndpointOverview(props) {
endpointsDispatcher({
action: 'select_endpoint_type',
value: {
endpointImplementationType: 'ENDPOINT',
endpointImplementationType: ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT,
endpointConfig: { ...generatedEndpointConfig },
},
});
Expand All @@ -605,7 +611,7 @@ function EndpointOverview(props) {
endpointsDispatcher({
action: 'select_endpoint_type',
value: {
endpointImplementationType: 'ENDPOINT',
endpointImplementationType: ENDPOINT_IMPLEMENTATION_TYPE_ENDPOINT,
endpointConfig: { ...generatedEndpointConfig },
},
});
Expand Down Expand Up @@ -782,7 +788,8 @@ function EndpointOverview(props) {
aria-label='EndpointType'
name='endpointType'
className={classes.radioGroup}
value={endpointType.key === 'MOCKED_OAS' ? 'INLINE' : endpointType.key}
value={endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS
? ENDPOINT_IMPLEMENTATION_TYPE_INLINE : endpointType.key}
onChange={handleEndpointTypeSelect}
>
{supportedEnpointTypes.map((endpoint) => {
Expand All @@ -804,7 +811,8 @@ function EndpointOverview(props) {
</FormControl>
</Grid>
<Grid item xs={12}>
{(endpointType.key === 'INLINE' || endpointType.key === 'MOCKED_OAS') ?
{(endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_INLINE
|| endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS) ?
iff(Object.keys(swaggerDef.paths).length !== 0,
<MockImplEndpoints
key={endpointType.key}
Expand Down Expand Up @@ -956,7 +964,7 @@ function EndpointOverview(props) {
)
: (
<>
{endpointType.key === 'prototyped'
{endpointType.key === ENDPOINT_TYPE_PROTOTYPED
? (
<Typography>
<FormattedMessage
Expand Down Expand Up @@ -1096,7 +1104,8 @@ function EndpointOverview(props) {
: (
<GenericEndpoint
autoFocus
name={endpointType.key === 'prototyped'
name={endpointType.key
=== ENDPOINT_TYPE_PROTOTYPED
? (
<FormattedMessage
id={'Apis.Details.Endpoints.'
Expand Down Expand Up @@ -1129,7 +1138,7 @@ function EndpointOverview(props) {
/>
)}
</Collapse>
{endpointType.key === 'prototyped' ? <div />
{endpointType.key === ENDPOINT_TYPE_PROTOTYPED ? <div />
: (
<div>
{componentValidator.includes("typeSANDBOX") &&
Expand Down Expand Up @@ -1296,8 +1305,10 @@ function EndpointOverview(props) {
</Paper>
)}
</Grid>
{endpointType.key === 'INLINE' || endpointType.key === 'MOCKED_OAS' ||
endpointType.key === 'prototyped' || endpointType.key === 'awslambda' || api.type === 'WS' || endpointType.key === 'sequence_backend'
{endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_INLINE
|| endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS
|| endpointType.key === ENDPOINT_TYPE_PROTOTYPED || endpointType.key === 'awslambda'
|| api.type === 'WS' || endpointType.key === 'sequence_backend'
? <div />
: (
<Grid item xs={12}>
Expand All @@ -1315,10 +1326,10 @@ function EndpointOverview(props) {
</Grid>
)}
{
endpointType.key === 'INLINE'
|| endpointType.key === 'MOCKED_OAS'
endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_INLINE
|| endpointType.key === ENDPOINT_IMPLEMENTATION_TYPE_MOCKED_OAS
|| endpointType.key === 'default'
|| endpointType.key === 'prototyped'
|| endpointType.key === ENDPOINT_TYPE_PROTOTYPED
|| endpointType.key === 'sequence_backend'
|| api.type === 'WS'
|| endpointType.key === 'awslambda'
Expand Down
Loading
Loading