Repository navigation
Resolve shared Daon connections with full configuration - #8
Merged
ashanthamara merged 1 commit intoOct 19, 2026
Merged
Conversation
Closed
11 tasks
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UdeshAthukorala
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve the Daon connection referenced by
daon_idp_idwithSharedIdPResolveType.FULL_RESOLVED, so a connection shared from a parent organization returns the parent's full Daon authenticator configuration (OIDC credentials, endpoints and claim mappings) instead of the sub-organization's shadow connection.DaonReferencedIdpUtilto use thegetIdPByResourceIdoverload that takes aSharedIdPResolveType.DaonReferencedIdpUtilTestto mock the new overload.Related Issues
Summary by CodeRabbit