Update _solis.py - #1247
Open
DLafayetteII wants to merge 2 commits into
Open
Conversation
Adds support for fractional seconds, and a new error handling exception for other unexpected DateTime formats
DLafayetteII
requested review from
darienmorrow,
ddkohler,
kameyer226,
ksunden,
rpm4 and
untzag
as code owners
July 14, 2026 16:15
for more information, see https://pre-commit.ci
Contributor
|
a welcome addition. Thanks for putting in the work! Just add a quick note in the changelog.md and we should be good to go. |
ddkohler
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Date Time support for fractional seconds (which my newer Andor camera uses), and a new error handling exception for other unexpected Date Time formats, resolving Issue #1246.
Manually tested that both DateTime formats with fractional seconds and arbitrary formats now still allow for the data to be opened. Welcome any improvements in code quality/efficiency.
Changes
If Date Time has fractional seconds, we round to nearest integer and save the whole seconds as done previously.
If Date Time is an unexpected format, we provide the warning and save the file modified time instead.
Manually tested that both DateTime formats with fractional seconds and arbitrary formats now still allow for the data to be opened.
Checklist