Fixed the volc diags bounds crash#2353
Open
saneku wants to merge 2 commits into
Open
Conversation
Collaborator
|
The regression test results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed volcanic diagnostics bounds crash and minor volcanic transport fixes.
TYPE: bug fix
KEYWORDS: volcanic run, chem_opt=402, volcanic diagnostics, wet scavenging, emissions
SOURCE: Alexander Ukhov (KAUST)
DESCRIPTION OF CHANGES:
Problem:
Several volcanic diagnostic explicit interfaces declared volc_diags with a hard-coded third dimension of 1:9. The Registry-generated volcanic diagnostics package is sized by num_volc_diags, and p_ash_fall resolves to index 10. Debug builds with bounds checking therefore crashed in module_vash_settling when writing volc_diags(i,j,p_ash_fall). Optimized builds did not expose the bounds violation consistently.
Solution:
Replaced hard-coded volc_diags(...,1:9) declarations with volc_diags(...,num_volc_diags), and imported num_volc_diags where needed.
Additional minor fixes:
LIST OF MODIFIED FILES:
M chem/dry_dep_driver.F
M chem/emissions_driver.F
M chem/mechanism_driver.F
M chem/module_ctrans_grell.F
M chem/module_vash_settling.F
M chem/module_volc_chem.F
TESTS CONDUCTED:
RELEASE NOTE:
Fixed a volcanic diagnostics bounds crash for chem_opt=402 and included minor volcanic emissions / scavenging
fixes.