-
Notifications
You must be signed in to change notification settings - Fork 10
Add devcontainer configuration #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
896cd21
c395b91
b344f75
2f347e5
ae30f7f
969a7cc
3523dc3
1571267
981a518
ebc620a
ec9f1fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,13 @@ | ||||
| FROM mcr.microsoft.com/devcontainers/typescript-node:18 | ||||
|
|
||||
| USER node | ||||
|
|
||||
| WORKDIR /app/ | ||||
|
|
||||
| COPY --chown=node:node package*.json ./ | ||||
|
|
||||
| RUN npm install | ||||
|
|
||||
|
Comment on lines
+9
to
+10
|
||||
| RUN npm install |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
|
|
||
| services: | ||
| app: | ||
| build: | ||
| context: .. | ||
| dockerfile: .devcontainer/Dockerfile | ||
| volumes: | ||
| - ..:/app:cached | ||
| command: sleep infinity | ||
|
|
||
| volumes: | ||
| node_modules: | ||
|
Comment on lines
+8
to
+12
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,23 @@ | ||||||
|
|
||||||
| { | ||||||
| "name": "systemcore-blocks-interface", | ||||||
| "dockerComposeFile": "compose.yml", | ||||||
| "service": "app", | ||||||
| "remoteUser": "node", | ||||||
| "workspaceFolder": "/app/", | ||||||
| "customizations": { | ||||||
| "vscode": { | ||||||
| "extensions": [ | ||||||
| "dbaeumer.vscode-eslint", | ||||||
| "esbenp.prettier-vscode", | ||||||
| "bradlc.vscode-tailwindcss", | ||||||
| "ms-python.python" | ||||||
| ] | ||||||
| } | ||||||
| }, | ||||||
| "forwardPorts": [ | ||||||
| 3000 | ||||||
| ], | ||||||
| "postCreateCommand": "npm install", | ||||||
| "postAttachCommand": "npm run start" | ||||||
|
||||||
| "postAttachCommand": "npm run start" | |
| "postStartCommand": "npm run start" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .git/ | ||
| node_modules/ | ||
| *.log |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * text=auto eol=lf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
|
|
||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Motivation and Context | ||
| <!--- Why is this change required? What problem does it solve? --> | ||
| <!--- If it fixes an open issue, please link to the issue here. --> | ||
|
|
||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
|
|
||
| ## Screenshots (if appropriate): | ||
|
|
||
| ## Types of changes | ||
| <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would change API specifications or require data migrations) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| /// <reference types="vitest" /> | ||
| /// <reference types="@vitest/browser/matchers" /> | ||
|
|
||
| import { defineConfig } from "vitest/config"; | ||
| import { viteStaticCopy } from "vite-plugin-static-copy"; | ||
| import { playwright } from '@vitest/browser-playwright' | ||
|
|
@@ -24,6 +25,7 @@ export default defineConfig({ | |
| }), | ||
| ], | ||
| server: { | ||
| host: true, | ||
| port: 3000, | ||
| }, | ||
|
Comment on lines
27
to
30
|
||
| define: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devcontainer base image pins Node 18, but the current dependency tree includes packages that declare Node >= 20 in their
engines(seepackage-lock.json). Using Node 18 can lead to install/runtime failures (or strict engine errors). Please update the devcontainer image to a supported Node LTS that matches the project’s requirements (e.g., 20/22).