Skip to content

chore(deps): update dependency typescript to v6 #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjtorikian merged 6 commits into from
Apr 17, 2026
Merged

chore(deps): update dependency typescript to v6 #1554

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2ab99b
chore(deps): update dependency typescript to v6
renovate[bot] Apr 17, 2026
7b69f02
fix: Remove deprecated baseUrl from tsconfig for TypeScript 6 compati…
gjtorikian Apr 17, 2026
2287d09
update packages to support TS6
gjtorikian Apr 17, 2026
3908462
chore(deps): update @typescript-eslint packages for TypeScript 6 support
gjtorikian Apr 17, 2026
4c74fdf
fix: resolve merge conflicts with main
gjtorikian Apr 17, 2026
54c4293
chore: use caret range for typescript dependency
gjtorikian Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"publint": "^0.3.18",
"tsdown": "^0.21.0",
"tsx": "^4.20.6",
"typescript": "5.9.3",
"typescript": "6.0.3",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify TypeScript 6.0 build and typecheck compatibility

echo "=== Running typecheck script ==="
npm run typecheck

echo -e "\n=== Running build script ==="
npm run build

echo -e "\n=== Checking for TypeScript compiler errors in strict mode ==="
# Look for common TS 6.0 strictness issues in the flagged files
rg -n "\\[key: string\\]: any" src/vault/interfaces/key.interface.ts
rg -n "as unknown as" src/webhooks/webhooks.ts  
rg -n "as any" src/common/utils/runtime-info.spec.ts

Repository: workos/workos-node

Length of output: 1122

🏁 Script executed:

cat -n package.json | grep -A 5 -B 5 "jest"

Repository: workos/workos-node

Length of output: 1279

🏁 Script executed:

cat -n package.json | sed -n '80,95p'

Repository: workos/workos-node

Length of output: 534

🏁 Script executed:

# Check if there's a tsconfig.json with jest types
cat tsconfig.json | grep -A 10 "types"

Repository: workos/workos-node

Length of output: 138

🏁 Script executed:

git log --oneline package.json | head -5

Repository: workos/workos-node

Length of output: 142

🏁 Script executed:

# Check the previous TypeScript version
git show HEAD~1:package.json | grep -A 2 -B 2 '"typescript"'

Repository: workos/workos-node

Length of output: 98

🏁 Script executed:

# Check current git status and recent changes
git status

Repository: workos/workos-node

Length of output: 261

🏁 Script executed:

# Check if there's a git diff showing the changes
git diff HEAD package.json | head -30

Repository: workos/workos-node

Length of output: 44

🏁 Script executed:

# Look at the commit that updated TypeScript
git show 3908462:package.json | grep -A 2 -B 2 '"typescript"'

Repository: workos/workos-node

Length of output: 175

🏁 Script executed:

# Check what the jest types error actually means
# Try to see if there's a mismatch between jest version and `@types/jest`
npm ls jest `@types/jest`

Repository: workos/workos-node

Length of output: 117

🏁 Script executed:

# Check if there are any known issues with TypeScript 6.0 and `@types/jest` 30.0.0
# by looking at the jest configuration in package.json
cat -n package.json | grep -A 20 '"jest"'

Repository: workos/workos-node

Length of output: 1434

Address TypeScript 6.0 jest types compatibility issue and version pinning inconsistency.

Two issues to resolve:

  1. TypeScript 6.0 + jest types incompatibility: The typecheck script fails with "Cannot find type definition file for 'jest'" despite @types/jest being listed in devDependencies. This appears to be a breaking change between TypeScript 6.0.3 and @types/jest 30.0.0. Consider:

    • Upgrading @types/jest to a TypeScript 6.0-compatible version, or
    • Updating tsconfig.json's types configuration

  2. Version pinning inconsistency: This line uses exact version 6.0.3 while all other devDependencies use caret ranges (e.g., ^8.58.0, ^30.0.0). Change to ^6.0.3 for consistency unless exact pinning is intentional.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 85, The package.json currently pins "typescript":
"6.0.3" and your typecheck script fails to find Jest types; update package.json
to use a caret range for TypeScript (change "typescript": "6.0.3" to
"typescript": "^6.0.3") for consistency and either upgrade `@types/jest` to a
TypeScript 6-compatible release (bump "@types/jest" to a compatible version) or
adjust tsconfig.json's "types" (or "typeRoots") so Jest typings are included;
locate the "typecheck" script in package.json and the tsconfig.json "types"
array to make the corresponding change.

"typescript-eslint": "^8.46.0"
},
"engines": {
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"baseUrl": ".",
"allowSyntheticDefaultImports": true,
"alwaysStrict": true,
"esModuleInterop": true,
Expand Down
Loading