DTLS bugfix: check CID is newest before promoting new peer address#10626
Open
mattia-moffa wants to merge 1 commit into
Open
DTLS bugfix: check CID is newest before promoting new peer address#10626mattia-moffa wants to merge 1 commit into
mattia-moffa wants to merge 1 commit into
Conversation
Follows RFC 9146 § 6. Fixes wolfSSL#10609
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when DTLS CID was enabled and an app used
wolfSSL_dtls_set_pending_peer(),dtlsProcessPendingPeer()promoted the pending peer without checking that the record is newer than the newest already received. RFC 9146 § 6 requires to check this (second condition in the list). Without the check, a reordered or replayed CID record could cause an erroneous migration of the active peer.Fixes #10609
Testing
Checklist