Initial implementation#10584
Open
twcook86 wants to merge 2 commits into
Open
Conversation
|
dgarske
requested changes
Jun 3, 2026
| return 0; | ||
| } | ||
|
|
||
| int wc_PufDeinit(wc_PufCtx* ctx) |
Member
There was a problem hiding this comment.
Shouldn't this entire file not be compiled when WOLFSSL_NXP_PUF is defined? Maybe add a !WOLFSSL_NXP_PUF around it? Also did you consider extending the crypto callbacks to support PUF? So have an init_ex with devId/heap and support registering a PUF handler for the NXP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the lpc55s69 hw puf to wolfCrypt (WOLFSSL_HWPUF && WOLFSSL_NXP_PUF). An effort has been made to be as compatible with the sw puf (WOLFSSL_PUF) implementation as possible.
Not all features of the hw puf are supported yet. Specifically, this initial implementation supports...
Testing
Tested with new test functionality added to wolfcrypt/test/test.c
Checklist