Include draft content notice on pages with hero component#3801
Merged
Conversation
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: fffbaaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
matthewp
approved these changes
Apr 3, 2026
Merged
gxxxr-111
pushed a commit
to gxxxr-111/starlight
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
draftfeature, we added a notice to alert people during dev that page had draft status, but missed adding this same alert if the page used theherocomponent.Here’s an example of what this looks like if you set
draft: trueon the homepage of the Starlight docs:This also required a couple of minor CSS changes:
grid-template-columnson the hero component for small viewports, but this is risky when components can overflow the viewport width (like the draft notice) as the grid simply adapts to accommodate them. The hero is now explicitly a single, 100%-wide column for small viewports so it contains the notice.I think both of these changes are minor and should be safe enough to release in a patch.