Skip to content

refactor(astro): migrate astro-island-hydration-error e2e test to typescript #16647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aru-dev-ac wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −7
Open

refactor(astro): migrate astro-island-hydration-error e2e test to typescript #16647

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20a5446
refactor(astro): migrate astro-island-hydration-error e2e test to typ…
aru-dev-ac May 7, 2026
f881856
refactor(astro): use RegExp#exec to satisfy @typescript-eslint/prefer…
aru-dev-ac May 7, 2026
d86dd45
Merge remote-tracking branch 'upstream/main' into fix/migrate-orphan-…
aru-dev-ac May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .../e2e/astro-island-hydration-error.test.js → .../e2e/astro-island-hydration-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
import { expect } from '@playwright/test';
import { testFactory, waitForHydrate } from './test-utils.js';
import { type DevServer, testFactory, waitForHydrate } from './test-utils.ts';

declare global {
interface Window {
__hydrationErrorEvents?: Array<{ componentUrl: string; hasError: boolean }>;
}
}

const test = testFactory(import.meta.url, {
root: './fixtures/astro-island-hydration-error/',
});

test.describe('astro-island hydration error handling', () => {
let devServer;
let devServer: DevServer;

test.beforeAll(async ({ astro }) => {
devServer = await astro.startDevServer();
Expand Down Expand Up @@ -49,8 +55,8 @@ test.describe('astro-island hydration error handling', () => {
const html = await (await page.request.get(pageUrl)).text();
const componentUrl = getIslandComponentUrl(html);

const pageErrors = [];
const consoleErrors = [];
const pageErrors: string[] = [];
const consoleErrors: string[] = [];
page.on('pageerror', (error) => pageErrors.push(error.message));
page.on('console', (message) => {
if (message.type() === 'error') consoleErrors.push(message.text());
Expand All @@ -65,16 +71,16 @@ test.describe('astro-island hydration error handling', () => {

const hydrationErrors = await page.evaluate(() => window.__hydrationErrorEvents);
expect(hydrationErrors).toHaveLength(1);
expect(hydrationErrors[0].componentUrl).toContain(componentUrl.split('?')[0]);
expect(hydrationErrors![0].componentUrl).toContain(componentUrl.split('?')[0]);
expect(pageErrors).toEqual([]);
expect(
consoleErrors.some((message) => message.includes('[astro-island] Error hydrating')),
).toBe(false);
});
});

function getIslandComponentUrl(html) {
const match = html.match(/component-url="([^"]+)"/);
function getIslandComponentUrl(html: string): string {
const match = /component-url="([^"]+)"/.exec(html);
if (!match) {
throw new Error('Failed to find astro-island component-url in page HTML');
}
Expand Down
Loading