Skip to content

Document trusted patterns for semgrep#16423

Merged
matthewp merged 2 commits intomainfrom
semgrep-trusted-patterns
Apr 22, 2026
Merged

Document trusted patterns for semgrep#16423
matthewp merged 2 commits intomainfrom
semgrep-trusted-patterns

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

Changes

  • Adds narrow nosemgrep annotations where the flagged patterns are generated by Astro or framework internals rather than untrusted input.
  • Leaves runtime behavior unchanged while making future Semgrep runs easier to review across Astro and the affected integrations.

Testing

  • Installed dependencies in a fresh worktree to validate the split branch in isolation.
  • Ran Biome against the touched source files and changeset to confirm the branch stays formatted and lint-clean.

Docs

  • No docs update needed, because this only documents internal scan expectations.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

⚠️ No Changeset found

Latest commit: 8bf17f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing semgrep-trusted-patterns (8bf17f2) with main (a002540)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (32b361d) during the generation of this report, so a002540 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions Bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Apr 20, 2026
@matthewp matthewp merged commit b2d8eb3 into main Apr 22, 2026
27 checks passed
@matthewp matthewp deleted the semgrep-trusted-patterns branch April 22, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants