Skip to content

Refactor a few internal regex-based helpers#16421

Closed
matthewp wants to merge 1 commit into
mainfrom
semgrep-regex-refactors
Closed

Refactor a few internal regex-based helpers#16421
matthewp wants to merge 1 commit into
mainfrom
semgrep-regex-refactors

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

Changes

  • Replaces extension and base-path regex helpers with direct string handling in content and preview utilities.
  • Simplifies content render transform filtering so it no longer needs per-entry dynamic regex generation.

Testing

  • Installed dependencies in a fresh worktree to validate the split branch in isolation.
  • Ran Biome against the touched source files and changeset to confirm the branch stays formatted and lint-clean.

Docs

  • No docs update needed, because this only changes internal implementation details.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

🦋 Changeset detected

Latest commit: 61f56bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp
Copy link
Copy Markdown
Contributor Author

Moving this to draft, I don't know if all of these are necessary.

@matthewp matthewp marked this pull request as draft April 20, 2026 20:23
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing semgrep-regex-refactors (61f56bb) with main (a002540)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (32b361d) during the generation of this report, so a002540 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Apr 20, 2026
@matthewp
Copy link
Copy Markdown
Contributor Author

I don't think these are necessary, closing.

@matthewp matthewp closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant