refactor(ts-plugin): migrate tests to typescript

[ocavue]

Part of #16241

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3a9e685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ocavue]

We use @vscode/test-cli to run the test, which is based on mocha. I need require: ['tsx'] in order to run typescript test files in mocha.

[ematipico]

I'll keep this for last. The language tool is special I haven't taken that into account for the migration.

[ocavue]

I'll keep this for last. The language tool is special I haven't taken that into account for the migration.

Surely. I know this is not in your migration plan. Language tool (vscode) uses mocha, unlike other tests that use node:test and playwright. I simply want to get rid of all *.test.js files in the repo using this chance.

[ematipico]

@Princesseuh I would love your review here

[Princesseuh]

I don't think this test actually runs right now, IIRC it was super flaky when I moved it to the monorepo so I ended up skipping it. I can't seem to find it in the CI logs either, so guessing this is still the case

[ocavue]

Oh I forget to check CI log. The test runs fine on my local Mac environment.

[ocavue]

@Princesseuh I've added back the ts-plugin test to CI in 3a9e685.

Currently, this test only runs on Linux. The last push triggered two runs, one on Ubuntu with Node 20 and another on Ubuntu with Node 22. Both runs were successful.

Since you mentioned that this test is flaky, I ensured that this test won't break the CI. If the test fails, it will just print a warning message that can be seen in the GitHub Action UI using this syntax. We can merge the CI change and monitor whether this test is still flaky.

[Princesseuh]

This looks fine to me, but I'll let @ematipico decide if he thinks the flaky warning is ok or not!

[ematipico]

Thank you both. Let's keep it as is. If it starts bothering CI, we can silent them again