Repository navigation
ci: stop release-dry-run failing on every PR, by skipping versions already on npm - #351
Merged
Merged
Conversation
The release-dry-run job failed on every PR with "You cannot publish over the previously published versions". npm 11 (node 24) checks the registry in a dry run, and between releases js/package.json holds the last released version. ipyvue's dry run still passes because it uses node 20 (npm 10). The job now skips the dry run, with a log line, when that version is already on npm. After the version bump, the dry run checks the package as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maartenbreddels
marked this pull request as ready for review
October 6, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
release-dry-runjob stops failing on every PR: it skips the npm dry run when the version injs/package.jsonis already on npm.Problem
release-dry-runfails on every pull request with "You cannot publish over the previously published versions: 3.0.0".npm 11, which comes with node 24 in this job, checks the registry during
npm publish --dry-run.Between releases,
js/package.jsonholds the last released version, so the dry run always hits that check.A check that is always red teaches people to ignore it. ipyvue's dry run passes only because it still uses node 20 (npm 10).
Change
The job reads the version from the package tarball. When
npm view jupyter-vuetify@<version>finds it, the job logs that the dry run is skipped until the version bump, and stops with success. Otherwise it runs the dry run as before.Validation
jupyter-vuetify-3.0.0.tgz, the version check reads3.0.0and finds it on npm, so the job skips. For3.1.0it does not find it, so the job runs the dry run.Gaps
Align results
Caution
/alignwas not run on this change: a small CI fix that Maarten asked about.Crossreview results
One round, by astra and gpt-6.1-sol. Neither found a defect. Both checked that a missing version and a registry error both fall through to the dry run, and that a new release version is still checked.
🤖 Generated with Claude Code