Build list of selectedcontent elements to clear#11891
Closed
josepharhar wants to merge 5 commits into
Closed
Conversation
This PR improves the "clear a select's non-primary selectedcontent elements" algorithm by making it create a list of selectedcontent elements to modify separately from modifying them in order to prevent the list of elements to change while iterating. Fixes whatwg#11880
annevk
reviewed
Nov 21, 2025
Member
|
@josepharhar it doesn't seem like the tests in https://chromium-review.googlesource.com/c/chromium/src/+/7128135 have made their way to WPT. Any reason this appears to be stalled? |
annevk
approved these changes
Jan 13, 2026
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Looks good modulo nit, but the test needs sorting out.
Contributor
Author
Sorry, I will get it reviewed very soon |
Contributor
Author
|
The WPT changes have been merged |
Contributor
Author
|
This change is being included in #12263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the "clear a select's non-primary selectedcontent elements" algorithm by making it create a list of selectedcontent elements to modify separately from modifying them in order to prevent the list of elements to change while iterating.
Fixes #11880
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )