Skip to content

selectedcontent post-connection steps did not break out of the loop #11878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 4 commits into from
Jan 16, 2026
Merged

selectedcontent post-connection steps did not break out of the loop #11878

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24ccab9
selectedcontent post-connection steps did not break out of the loop
annevk Nov 4, 2025
94faffd
address review comments
annevk Jan 14, 2026
6a4898e
favor early return
annevk Jan 14, 2026
4fef23d
also early return for removed selectedcontent elements that are disabled
annevk Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59147,9 +59147,8 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s
replaces them with a new copy of the DOM structure of the <code>select</code>'s selected
<code>option</code> element.</p>

<p>Every <code>selectedcontent</code> element has a <dfn
data-x="selectedcontent-disabled">disabled</dfn> state, which is a boolean, initially set to
false.</p>
<p>Every <code>selectedcontent</code> element has a boolean <dfn
data-x="selectedcontent-disabled">disabled</dfn>, which is initially false.</p>

<div algorithm>
<p>To <dfn>update a <code>select</code>'s <code>selectedcontent</code></dfn> given a
Expand Down Expand Up @@ -59187,8 +59186,8 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s
<span>descendant</span> of <var>select</var> in <span>tree order</span> if any such element
exists; otherwise return null.</p></li>

<li><p>If <var>selectedcontent</var> is <span data-x="selectedcontent-disabled">disabled</span>,
then return null.</p></li>
<li><p>If <var>selectedcontent</var>'s <span data-x="selectedcontent-disabled">disabled</span> is
true, then return null.</p></li>

<li><p>Return <var>selectedcontent</var>.</p></li>
</ol>
Expand Down Expand Up @@ -59262,10 +59261,8 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s
<ol>
<li><p>Let <var>nearestSelectAncestor</var> be null.</p></li>

<li><p>Let <var>ancestor</var> be <var>selectedcontent</var>'s <span>parent</span>.</p></li>

<li><p>Set <var>selectedcontent</var>'s <span data-x="selectedcontent-disabled">disabled</span>
state to false.</p></li>
to false.</p></li>

<li>
<p>For each <var>ancestor</var> of <var>selectedcontent</var>'s <span
Expand All @@ -59277,20 +59274,21 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s

<ol>
<li><p>If <var>nearestSelectAncestor</var> is null, then set <var>nearestSelectAncestor</var>
to <var>select</var>.</p></li>
to <var>select</var> and <span>continue</span>.</p></li>

<li><p>Otherwise, set <var>selectedcontent</var>'s <span
data-x="selectedcontent-disabled">disabled</span> state to true.</p></li>
<li><p>Set <var>selectedcontent</var>'s <span
data-x="selectedcontent-disabled">disabled</span> to true and <span>break</span>.</p></li>
</ol>
</li>

<li><p>If <var>ancestor</var> is an <code>option</code> element or a
<code>selectedcontent</code> element, then set <var>selectedcontent</var>'s <span
data-x="selectedcontent-disabled">disabled</span> state to true.</p></li>
data-x="selectedcontent-disabled">disabled</span> to true and <span>break</span>.</p></li>
</ol>
</li>

<li><p>If <var>nearestSelectAncestor</var> is null or <var>nearestSelectAncestor</var> has the
<li><p>If <var>selectedcontent</var>'s <span data-x="selectedcontent-disabled">disabled</span> is
true, <var>nearestSelectAncestor</var> is null, or <var>nearestSelectAncestor</var> has the
<code data-x="attr-select-multiple">multiple</code> attribute, then return.</p></li>

<li><p>Run <span>update a <code>select</code>'s <code>selectedcontent</code></span> given
Expand All @@ -59306,6 +59304,9 @@ interface <dfn interface>HTMLSelectedContentElement</dfn> : <span>HTMLElement</s
<var>selectedcontent</var> and <var>oldParent</var>, are:</p>

<ol>
<li><p>If <var>selectedcontent</var>'s <span data-x="selectedcontent-disabled">disabled</span> is
true, then return.</p></li>

<li>
<p>For each <var>ancestor</var> of <var>selectedcontent</var>'s <span
data-x="ancestor">ancestors</span>, in reverse <span>tree order</span>:</p>
Expand Down