Repository navigation
perf(types): check declaration values per property and add app-scale type benches - #515
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
|
Contributor
Site previewCommit: |
commit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #513. Adds app-scale type benchmarks and trims declaration checking further. Types only; no API change.
Changes
Value.AcceptedValue/Value.CheckedValue: check a declaration value against its property directly, instead of through a one-keyRecord/Pickwrapper, so TypeScript caches each check per (value, property, tokens).Style.AcceptedMembercalls them directly.Value.Scalar: a dimension is matched against every unit suffix only when a range rule can reject it (negative, or required positive). That unit matching was the largest single cost, about 275k instantiations on the fixture.Benchmarks
src/default.bench-d.ts: app-scale authoring against the bundled default theme (token declarations, mixed literal/token, nested conditions, repeated declarations, a recipe).create / configured styles with shorthandscase inConfig.bench-d.ts, coveringConfiguration.Body.pnpm update:types. They were stale from before perf(types): check style declarations by key and value #513 (many cases 30–90% under).Results
Fixture: Pyramid
apps/webconfig plus its 2,040styleand 258variantscalls, TypeScript 7 (tsgo), single thread.The new default-theme benches drop 20–35%. No bench case regressed (66 cases).
Checks
pnpm check:types: clean, so every@ts-expect-errorin*.test-d.tsstill fires.pnpm bench:types: all fixtures pass.vp fmtandvp linton changed files: clean.